Add timeout fine-tunning advanced docs section#476
Merged
Conversation
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this and congrats on the write up! I left a couple of phrasing suggestions. Excited about how helpful this will be for users. :-)
mwoss
commented
Oct 14, 2019
mwoss
left a comment
Contributor
Author
There was a problem hiding this comment.
Done. I rephrased most of the dosc, using your suggestions (more like copying it) - I really like your writing style. :)
florimondmanca
approved these changes
Oct 16, 2019
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looking good to me -- thanks again for putting this together!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue #434
I've added a small intro to HTTPX timeouts, sections with examples (plain request, client, timeout config object) and a paragraph about disabling timeouts.
btw, I apologize for any grammar mistakes, English is my second language.