[pull] main from livekit:main - #455
Merged
Merged
Conversation
* agent simulation: name the run window bounds start_time/end_time `from` is a Python keyword, so protoc's --pyi_out cannot emit a parameter for it: the stub drops the attribute and falls back to an untyped `**kwargs`, which python-sdks' strict mypy gate rejects, and no Python caller can reach the field except through getattr. Rename both bounds together to keep the pair symmetric and to match the _time suffix the timestamps elsewhere use. Field numbers are unchanged, so the wire format is compatible; only the JSON/text names move. * generated protobuf
* rpc: gate the claim skip process-wide for every server Wires psrpc's WithServerSkipClaim into WithServerObservability, which is the one seam every server constructor shares -- WithDefaultServerOptions calls it, and the constructors that take only a logger reach it too. The setting is process-wide because the claim is a transport policy rather than a per-service one, and it is read per request so callers may set it before or after their servers exist and revoke it without a redeploy. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * pin psrpc v0.7.5, trim comments Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * rename the skip-claim gate to carry the psrpc prefix Server and client mean too many things in this package for a bare SetServerSkipClaim to read clearly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* log agent dispatch metadata size * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
protoc's plugins were unpinned inputs to committed code: the generate
workflow installed all four with `go install ...@latest`, ran mage from
`mage-action` with `version: latest`, and floated protoc within its
major. Worse, every `--plugin=` flag in the magefile used the short form
(`--plugin=go=`), which protoc silently ignores, so generation actually
ran whatever binary happened to be in GOPATH/bin.
Pin each generator to the version stamped in the committed headers:
- protoc-gen-go, -go-grpc, -psrpc, -twirp and mage become `tool`
directives in go.mod, resolved at generation time with `go tool -n`
- the `--plugin=` flags use the full-executable-name form protoc
honours, so those pinned paths are actually used
- protoc is pinned exactly rather than floated within its major; it
stamps its version into every generated file, so a bump rewrites
the committed output and should be a reviewable edit
- release.yaml gets the same protoc pin: it builds the published JS
package via `pnpm generate:proto`, so protoc is a release input
google.golang.org/protobuf moves 1.36.11 -> 1.36.12 because 1.36.12 is
what generated the committed files; pinning to 1.36.11 would land a
downgrade of every header disguised as a pin. Verified by regenerating
with the pinned protoc: the generated tree comes back byte-identical.
GOPATH/bin here held older plugins (protoc-gen-go v1.36.11, psrpc
v0.7.0), so an empty diff also proves the plugin paths are honoured
rather than falling back to PATH.
`mage bootstrap` stays as a developer convenience for installing the
plugins system-wide, documented as such: it is not a build step, and
generation ignores what it installs. bootstrap.sh is removed - it did
the same job pinned to protoc-gen-go v1.31.0 and psrpc v0.5.1, and
nothing referenced it.
renovate.json moves off the deprecated config:base to the baseline used
across the Go repos: third-party modules ungrouped so a bad bump reverts
alone, livekit deps grouped and exempt from quarantine, pion grouped
because they are co-released, a vulnerability fast path, and both the
go and toolchain directives disabled - this module is a library, so its
go directive is the minimum we ask of consumers. Drops the stale
go 1.22 constraint, four minors behind go.mod.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )