Part of #4511, the sync of plan analysis changes from PerformanceStudio (PS) to PerformanceMonitor (PM). Uses the masking helper from #4524.
On Standard Edition, SQL Server limits a query with batch mode operators to DOP 2. PS rule 38 fires when a plan runs at DOP 2 and has a batch mode operator. Its severity is Warning when the server is known to be Standard Edition with a MAXDOP above 2. It is Info when the edition is not known. It does not fire when the query text has a MAXDOP 2 hint, because the limit is then intentional.
erikdarlingdata/PerformanceStudio@6f9e2d6 adds the rule, and erikdarlingdata/PerformanceStudio@ed64dbc adds the hint check. erikdarlingdata/PerformanceStudio@dcec793 makes the hint check search the masked text.
PlanAnalyzer.Analyze(ParsedPlan plan) (PlanAnalyzer.cs:23) takes no server metadata. PM already collects the edition (SERVERPROPERTY('EngineEdition') in DarlingServerConnector.cs:117) and the max degree of parallelism setting. The work is to pass them into Analyze, and the rule itself is small. Size L.
At 1899737f. dev has no later change to PerformanceMonitor.PlanAnalysis.
Part of #4511, the sync of plan analysis changes from PerformanceStudio (PS) to PerformanceMonitor (PM). Uses the masking helper from #4524.
On Standard Edition, SQL Server limits a query with batch mode operators to DOP 2. PS rule 38 fires when a plan runs at DOP 2 and has a batch mode operator. Its severity is Warning when the server is known to be Standard Edition with a MAXDOP above 2. It is Info when the edition is not known. It does not fire when the query text has a
MAXDOP 2hint, because the limit is then intentional.erikdarlingdata/PerformanceStudio@6f9e2d6 adds the rule, and erikdarlingdata/PerformanceStudio@ed64dbc adds the hint check. erikdarlingdata/PerformanceStudio@dcec793 makes the hint check search the masked text.
PlanAnalyzer.Analyze(ParsedPlan plan)(PlanAnalyzer.cs:23) takes no server metadata. PM already collects the edition (SERVERPROPERTY('EngineEdition')inDarlingServerConnector.cs:117) and the max degree of parallelism setting. The work is to pass them intoAnalyze, and the rule itself is small. Size L.At
1899737f.devhas no later change toPerformanceMonitor.PlanAnalysis.