Skip to content

Collector health status text: fixed Brushes.OrangeRed fails WCAG contrast on Light theme #4635

Description

@erikdarlingdata

What happens

Outside the plan viewer, CollectorHealthText.Foreground is set to the fixed
System.Windows.Media.Brushes.OrangeRed (#FF4500) in two places:

  • Lite/MainWindow.xaml.cs (erroring collectors, dead XE capture, and a third status this
    same pattern covers)
  • Darling/PerformanceMonitor.Darling.Viewer/MainWindow.ServerManagement.cs (same status text)

This is the same fixed, theme-unaware brush #4629 just replaced in the plan viewer for the
same reason: #FF4500 measures 3.44:1 against a white Light background, under WCAG AA's 4.5:1
floor for text, and 4.46:1 against Dark's node background (also just under the floor).

Suggested fix

Route these through the same theme-aware PlanCriticalOrangeBrush / PlanCriticalOrangeColor
resource #4629 added to Lite's, the Dashboard's, and the Darling Viewer's LightTheme.xaml,
DarkTheme.xaml and CoolBreezeTheme.xaml (Light/CoolBreeze #A83A0D, Dark #FF7043, both

= 4.5:1 against every page/card/node background in their theme) — or another theme resource,
if the status bar's background differs enough that those two values don't clear the floor
there too.

Why this wasn't folded into #4629

#4629 was scoped to plan-viewer rendering in PerformanceMonitor.PlanAnalysis and
PerformanceMonitor.Ui. MainWindow.xaml.cs/MainWindow.ServerManagement.cs are each
app's own status-bar code, a different subsystem, not shared between Lite and the Dashboard.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions