Repository navigation
Plan viewer: the empty Server Context card no longer points to the repro script - #4631
Merged
Merged
Conversation
erikdarlingdata
marked this pull request as ready for review
September 28, 2026 19:27
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4623. Part of #4511.
Why
The empty Server Context card said "Run Repro Script to capture server context", copied from PerformanceStudio. In PerformanceMonitor the card fills only from the
ServerMetadataa host sets from its own store; running the repro script never fills it.Hosts that set
ServerMetadata: the Lite server tab, the Lite plan window and drill-down collector, the Darling Viewer server tab, the actual-plan flow, and the procedure, query-stats, Query Store and wait drill-down windows. It stays null for a pasted plan, a file open, andanalyze_plan_xml.What changes
ServerContextCard.EmptyText: "Server context is shown for plans opened from a monitored server's data."ShowServerContext()sets the text from the constant when there are no rows.Lite gets this too (shared control). PM-ahead: the wording differs from PerformanceStudio on purpose, because its text is false here.
Test plan
Viewer4623Tests(2 pins): the constant's exact text with no "Repro"; a source pin that the XAML has no literal and the code uses the constant.ServerContextCard.EmptyTextdoesn't exist), and the source pin would also fail on the old XAML literal.Total: 83, Failed: 0(Viewer4623Tests, DocCommentHygieneTests, CommentFilterAdoptionTests);Total: 68, Failed: 0for every*Census*class plus McpPayloadContractCensusTests. Darling.Tests build: 0 warnings, 0 errors.CHANGELOG
None: the Server Context card is new in this release (#4614), so its empty-state text never shipped.