Repository navigation
Pin the scratch store session to UTC in live tests - #4645
Merged
Merged
Conversation
erikdarlingdata
marked this pull request as ready for review
September 28, 2026 20:42
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4639
What changed
ScratchPostgresnow builds its connection string throughDarlingStoreConnection.PinSessionTimeZoneUtc, the same pin the product applies. Every scratch-store live test (97 files) now runs in a UTC session whatever the cluster default is.Why
RollupFloorCacheLiveTestsreads a chunk'srange_endand passes it back as$1::timestamp. In a session behind UTC that cast moves the cutoff earlier, sodrop_chunkskeeps the chunk and the test fails.Test-only, not product
Every non-test store connection (
NpgsqlConnection,NpgsqlDataSource.Create,NpgsqlDataSourceBuilder) in Service, Storage and Viewer goes throughPinSessionTimeZoneUtc. Two Service connections inDarlingWorker(about lines 4327 and 9872) openruntime.ConnectionStringwithout it. Both belong to monitored-target paths, not the store, so I left them alone.Verification (local TimescaleDB rig, cluster and OS zone America/New_York)
RollupFloorCacheLiveTestson dev: 1 failed.IntervalFirstExecIndexRungTests(6),RollupCoverageCeilingLiveTests(1),RefreshCeilingStalenessTests(18),TempDbCeilingStoreTests(12).DocCommentHygieneTests(77),CommentFilterAdoptionTests(4),McpPayloadContractCensusTests(68),StorageCommandTimeoutTests(19),StartupCommandTimeoutTests(15). 0 build warnings.*Census*classes printed no totals, so CI decides those.CHANGELOG
None: test-only change (the scratch-store test fixture pins its session to UTC).