Match the Dashboard's Cool Breeze warning color to Lite's, fixing dev's theme-parity test - #4668
Merged
Merged
Conversation
#4658 darkened Cool Breeze's WarningColor from #9E4A0B to #9C490B in Lite and the Darling Viewer. The Dashboard's copy kept #9E4A0B, so ThemeParityTests, which requires the shared keys of the two apps' theme files to match, failed for CoolBreeze on dev and in every PR's Windows build. Set the Dashboard's WarningColor to #9C490B. WarningBrush derives from it, so both keys match again. The contrast figures in the file's comments now describe the new color.
erikdarlingdata
marked this pull request as ready for review
September 28, 2026 22:12
This was referenced Sep 28, 2026
erikdarlingdata
added a commit
that referenced
this pull request
Sep 28, 2026
…4674) ThemeParityTests in deprecated/Dashboard.Tests reads Lite/Themes/*.xaml, but the build's dashboard filter covered only deprecated/Dashboard/** and deprecated/Dashboard.Tests/**. #4658 changed only a Lite theme color, its build logged "Filter dashboard = false", the test was skipped, and dev went red until #4668. .github/workflows/build.yml: - The dashboard filter also matches Lite/Themes/**/!(*.md), with a comment saying why. - The Build Dashboard.Tests and Run Dashboard tests steps also run when installer_core changes. The Dashboard references Installer.Core, and that filter's comment already said a change there rebuilds both products, but only the CLI Installer's steps checked it. Proof: a throwaway draft (#4675, closed unmerged) with only a Lite theme comment on top of this branch logged "Filter dashboard = true", matching only Lite/Themes/CoolBreezeTheme.xaml. Refs #4673
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4651
What was wrong
#4658 darkened Cool Breeze's
WarningColorfrom#9E4A0Bto#9C490Bin Lite and the Darling Viewer, so warning text clears 4.5:1 on the plan viewer's properties panel. The Dashboard's copy of the theme kept#9E4A0B.ThemeParityTestsrequires the keys the Dashboard and Lite theme files share to match. On dev it now fails:#4658's own CI didn't run this test. The build's
dashboardpath filter covers onlydeprecated/Dashboard/**anddeprecated/Dashboard.Tests/**, and #4658 changed only Lite and Darling Viewer theme files.What changed
deprecated/Dashboard/Themes/CoolBreezeTheme.xaml:WarningColoris#9C490B, the value Darken Cool Breeze's default WarningColor to clear the 4.5:1 text floor (#4651) #4658 gave Lite and the Darling Viewer.WarningBrushis built fromWarningColor, so it follows.BackgroundDarkColor, 4.91:1 onBackgroundColor, 5.62:1 onBackgroundLightColor, and white text 6.23:1 on the color itself. The Dashboard's Cool Breeze backgrounds are the same as Lite's.deprecated/changes. Erik approved this one-file exception to the no-deprecated/rule.git diff --stat origin/dev...HEADshows only this file.Tests
ThemeParityTestsfails CoolBreeze with the two mismatches above (1 of 3 failed).ThemeParityTestspasses 3 of 3 (Dark, Light and CoolBreeze, all six theme files).Dashboard.Tests: 838 of 838 pass.ThemeColorOverrideTests109,ThemeCompletenessTests2,ThemeParityLiteDarlingTests3,ThemeStatusContrastTests21 andTagColorPaletteTests10 in Lite.Tests;Viewer4629Tests24 andViewerThemeColorOverridesTests4 in Darling.Tests.CHANGELOG
SECTION: None - the Dashboard gets the same Cool Breeze warning color #4658 gave Lite and the Darling Viewer, and the plan viewer it shares with them shows the same text, so #4658's entry covers this change once its "In Lite and the Darling Viewer" scope also names the Dashboard.