[FEATURE]

[joshdbe]

Which component(s) does this affect?

• Desktop App
• CLI Tool
• SSMS Extension
• Plan Analysis Rules
• Documentation

Problem Statement

Can you please add "Open Query" to File menu.

Proposed Solution

Add "Open Query" to File menu.

Use Case

Open existing query

Alternatives Considered

No response

[erikdarlingdata]

This already works — File → Open .sqlplan... opens .sql files too. The picker has a "SQL Scripts (*.sql)" filter in it, and anything ending in .sql gets loaded into a new query session tab named after the file rather than being treated as a plan. Dragging a .sql file onto the window does the same thing.

So the feature is there and the menu is lying about it. "Open .sqlplan..." gives you no reason to think it takes anything but a plan, which is presumably why you went looking for a separate item. Both the .sql handling and that label have been in place since the first release, so this isn't something that broke — it just never described itself properly.

Before I change it, which would actually have helped you?

1. Rename it to Open... so one item honestly covers plans and queries.
2. Leave it and add a separate Open Query... underneath New Query, filtered to .sql.

I lean toward 2, since New Query is already sitting right there and that's where your eye goes when you want to work with a query. But you're the one who went looking and didn't find it, so your instinct about where it belongs is worth more than mine here.

One other thing worth raising while you're in this part of the app: there's currently no Save Query. You can open a .sql, edit it, and then have nowhere to write it back to. If you're opening existing queries you're presumably also going to want to save them, so tell me if that's part of what you're after and I'll do both together.

[joshdbe]

Agree on separate Open Query.. and Save Query....
Thank you

[erikdarlingdata]

Done — merged to dev in #459.

You now get Open Query... (Ctrl+Shift+O) and Save Query... (Ctrl+S) sitting directly under New Query, which is where you went looking in the first place. Open .sqlplan... keeps its own item and Ctrl+O, and still takes .sql files for anyone who'd already worked that out.

Save prompts every time, but it defaults to the file the query came from and opens the picker in that folder — so saving back over what you opened is the easy path, and Save As is the same gesture with a different name typed in. Save somewhere new and the tab retitles itself to match.

The nightly builds off dev at 06:00 UTC, so tonight's will have it: https://github.com/erikdarlingdata/PerformanceStudio/releases/tag/nightly

Since you're the one who noticed the gap, I'd rather you kicked the tyres than me:

• Open a .sql you actually work in, edit it, Ctrl+S, and confirm it went back where you expected without a second prompt fighting you.
• Save As somewhere new and check the tab renames and that the original file is untouched.
• Open several at once — the picker takes multiple files and each should land in its own tab.

Two things it deliberately does not do, so you're not surprised: there's no unsaved-changes warning when you close a tab, and query tabs still don't reopen when you restart the app the way plan tabs do. Say the word if either of those is what you actually needed and I'll open issues for them.

One unrelated thing your report shook loose: the error dialog for a file that won't open was calling ShowDialog against the main window before it was visible, which meant a corrupt or missing file passed on the command line crashed the app at launch instead of telling you what was wrong. That's been in there since the beginning and I only found it because a test for the new save path made a write fail. So thanks for the nudge — it was worth more than the menu item.

[joshdbe]

Hello Erik. Thank you, all saves work as expected.
As per your question. Yes, it would be nice when closing app it will let you know that there are unsaved change. Also when changing the query it would change X to circle next to query name (like VS Code does)
And when reopening app it would preserve whatever was open before closing.
Thank you very much, I appreciate your work.
Josh

p.s. There is another thing I find a little uncomfortable: the partial autohide of horizontal scroll bars. I would prefer normal size.

[erikdarlingdata]

Thanks for actually testing it — that's the part people skip.

This shipped in v1.22.0 this morning, so it's out of the nightly and into a signed release: https://github.com/erikdarlingdata/PerformanceStudio/releases/tag/v1.22.0

Your four follow-ups are all real, and I've split them by what they actually cost:

• Warn about unsaved query changes, and mark modified tabs #462 — unsaved changes. Your first two points are one feature wearing two hats. A query session currently has no idea whether it's been edited, and once it does, both the close prompt and the VS Code style dot on the tab fall out of the same flag. You're right about the dot, including the bit you didn't say out loud: it goes back to an × on hover so you can still close the thing.
• Restore query tabs on restart, and let Copy Path see them #463 — reopening what was open. This one is nearly free and I'm slightly annoyed I didn't do it in Give queries their own Open and Save in the File menu (#458) #459. GetTabFilePath only knows how to look inside plan tabs, so it returns nothing for a query tab even though the query tab has known its own file path since Give queries their own Open and Save in the File menu (#458) #459. Teaching it one more shape restores query tabs and un-hides Copy Path on their right-click menu, which has silently never worked. Caveat: this brings back tabs that came from a file. A scratch tab you never saved still won't return, because there's nowhere it was.
• Stop autohiding scrollbars #464 — the scrollbars. Straightforwardly my fault and straightforwardly right. AllowAutoHide was never set, so everything inherited Fluent's default of collapsing the bar to a sliver until you hover it. That's a bad trade on a horizontal bar under a wide grid — the thing you need to grab is two pixels tall until after you've found it. Going to normal size everywhere rather than making it a setting.

Closing this one, since the menu items you asked for are shipped and confirmed working. The three above carry the rest.