Drop the unused AvaloniaEdit.TextMate.Grammars package - #552
Merged
Merged
Conversation
No app code ever referenced it: the package ships its own RegistryOptions and ThemeName under the AvaloniaEdit.TextMate.Grammars namespace, and every call site binds the TextMateSharp.Grammars pair instead, which arrives through the TextMateSharp.Grammars 2.0.4 reference that stays. Dropping it also removes Newtonsoft.Json 13.0.1 and the stale TextMateSharp 1.0.23 floor from the resolved graph. Kept out of the Avalonia 12 migration deliberately (a runtime-graph change had no place in that release); shipping now as its own change. Fixes #545 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sr43FouJ6RizUyoWQeR5FX
|
Reviewed. This is a clean, well-scoped removal — confirmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545. The package was never referenced by app code — its RegistryOptions/ThemeName live in a namespace the app never imports, while every call site uses TextMateSharp.Grammars (still directly referenced at 2.0.4). Removing it drops Newtonsoft.Json 13.0.1 and the TextMateSharp 1.0.23 floor from the resolved graph. Verified: Release build 0/0, full suite 712 passed / 1 known skip, TextMateSharp still resolves via the direct pin, Newtonsoft gone from project.assets.json. Deliberately excluded from the Avalonia 12 PR to keep that release migration-only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Sr43FouJ6RizUyoWQeR5FX