Skip to content

Let the escape-brackets label keep its underscore - #553

Merged
erikdarlingdata merged 1 commit into
devfrom
fix/547-escape-brackets-label
Sep 22, 2026
Merged

erikdarlingdata merged 1 commit into
devfrom
fix/547-escape-brackets-label

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Fixes #547. The checkbox label 'Treat [ ] _ as literals' lost its underscore to mnemonic parsing — AccessText eats the first underscore as an access-key marker, in Avalonia 11 and 12 alike. Doubling it (__) renders a literal underscore. One character; Release build 0/0 and full suite 712/1-skip green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Sr43FouJ6RizUyoWQeR5FX

AccessText takes the character after the first underscore as an
access key and strips the underscore from display, so "Treat [ ] _
as literals" rendered without the one character that is half of what
the checkbox is about. Doubling it is the escape: __ renders as a
literal underscore and registers no access key.

Fixes #547

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sr43FouJ6RizUyoWQeR5FX
@claude

claude Bot commented Sep 22, 2026

Copy link
Copy Markdown

Reviewed. The fix is correct and minimally scoped: doubling the underscore in the CheckBox Content is the standard Avalonia AccessText escape (same convention as WPF) — a literal _ in mnemonic-parsed text must be written as __, otherwise it's consumed as an access-key marker and dropped from the rendered label. Confirmed the only other place this string appears is the unrelated CLI help text in QueryStoreCommand.cs (plain Description, not run through AccessText), so no inconsistency there. No correctness, security, or repo-convention issues — LGTM.

@erikdarlingdata
erikdarlingdata merged commit 2af84be into dev Sep 22, 2026
3 checks passed
@erikdarlingdata
erikdarlingdata deleted the fix/547-escape-brackets-label branch September 22, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant