Make bignum arithmetic count reductions#11274
Open
bjorng wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 3 files 136 suites 47m 38s ⏱️ Results for commit 4606e5e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
a59a1be to
0439e96
Compare
0439e96 to
28b5d22
Compare
be8fe3c to
340fe5e
Compare
sverker
reviewed
Jun 24, 2026
340fe5e to
b89942a
Compare
sverker
reviewed
Jun 24, 2026
b89942a to
a1b381c
Compare
sverker
approved these changes
Jun 24, 2026
sverker
requested changes
Jun 24, 2026
sverker
left a comment
Contributor
There was a problem hiding this comment.
The BUMP_REDS macro contains a lock check assertion that fails when called from a match spec that passes a dummy pseudo process as argument.
#5 0x56785602 in erts_lc_assert_failed (file=0x56a15725 "beam/erl_arith.c", line=400, assertion=0x569bc850 "ERTS_PROC_LOCK_MAIN & erts_proc_lc_my_proc_locks(p)") at beam/erl_lock_check.c:742
#6 0x5671562b in erts_mixed_plus (p=0xf3f23ce0, arg1=, arg2=3999773434) at beam/erl_arith.c:400
#7 0x567157b4 in splus_2 (A__p=0xf3f23ce0, BIF__ARGS=0xf5261ef0, A__I=0x0) at beam/erl_arith.c:72
#8 0x56757892 in db_prog_match (c_p=, self=, bprog=, term=, termp=, arity=, in_flags=, return_flags=) at beam/erl_db_util.c:2595
Provoked by debug emulator with
stdlib/test/ets_SUITE:t_match_spec_run
emulator/test/match_spec_SUITE:trace_control_word
03016e8 to
c918683
Compare
Contributor
Author
|
I've added a test to avoid bumping reductions for pseudo processes. |
This will make scheduling fairer when doing many arithmetic operations with large integers.
c918683 to
4606e5e
Compare
sverker
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make scheduling fairer when doing many arithmetic operations with large integers.