Skip to content

Add Uri with support for regexUri and globUri#6696

Merged
devyte merged 28 commits into
esp8266:masterfrom
Bmooij:feature/multi_uri
Feb 22, 2020
Merged

Add Uri with support for regexUri and globUri#6696
devyte merged 28 commits into
esp8266:masterfrom
Bmooij:feature/multi_uri

Conversation

@Bmooij

@Bmooij Bmooij commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

Add support for regex uri and glob uri.
This pull request is a combination of:
#5214
#5467

There is an issue when importing <regex>

@Bmooij

Bmooij commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

BTW it is not tested on a real device, because I don't own an esp8266

@d-a-v

d-a-v commented Nov 1, 2019

Copy link
Copy Markdown
Collaborator

@Bmooij How did you test it if not on real esp8266 ?
Do you know you can test that kind of code on your dev computer using emulation on host (cd tests/host/; make) ?

@Bmooij

Bmooij commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

I tested a similar implement on my esp32

But emulating sounds interesting. I will look into that later.

@devyte

devyte commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

@Bmooij there seem to be some warnings (unused params)

@devyte

devyte commented Nov 6, 2019

Copy link
Copy Markdown
Collaborator

Fixes #2019

@Bmooij

Bmooij commented Dec 27, 2019

Copy link
Copy Markdown
Contributor Author

There is an issue when using the regex lib for esp8266
See: #6952

@Bmooij

Bmooij commented Dec 27, 2019

Copy link
Copy Markdown
Contributor Author

I replaced the <regex> lib, with <regex.h> because it crashes and it has limitations. See #6198 (comment)

I tested it with an esp8266.
Everything works as expected now!

Make the example match the existing examples which allow setting
the SSID/PSK in the local platform.txt file.

@earlephilhower earlephilhower left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, works well. I did a couple trivial tweaks to the example to match the others instead of bothering you for them, but it all looks good.

Only thing missing is some documentation, but the example does show what I think would be a couple common use cases, so approving. We may want to open up a new bug to update the docs with these new calls, but that shouldn't impede this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants