fix(deps): move pnpm overrides to pnpm-workspace.yaml - #182
Merged
Merged
Conversation
pnpm 11 no longer reads the `pnpm` field from package.json, so the js-yaml / brace-expansion overrides were silently ignored while the lockfile still recorded them. Frozen installs under pnpm 11 then abort with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH, which kills the publish job in its "Bump version (patch)" step and blocks all releases. Move the overrides verbatim into pnpm-workspace.yaml, which pnpm 11 does read. The lockfile is unchanged (lockfileVersion '9.0'), so the lint job's pinned pnpm 10 keeps working. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
PR Summary by QodoMove pnpm overrides to workspace configuration
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The recent dependency sweep put the js-yaml / brace-expansion overrides into the
pnpm.overridesfield ofpackage.json, and regenerated the lockfile with pnpm 10.pnpm 11 no longer reads the
pnpmfield frompackage.json. It warns:and then ignores it. CI's publish job runs pnpm 11, so it sees no overrides while
the lockfile records them, and the frozen install aborts:
The publish job dies in its "Bump version (patch)" step, so this plugin cannot
release at all until this is fixed. The dependency fix itself is correct — only
its location was wrong.
Fix
Move the overrides verbatim from
package.jsonintopnpm-workspace.yaml, whichpnpm 11 does read. The override values are unchanged, and so is the lockfile
(
lockfileVersion: '9.0'), so the lint job's pinned pnpm 10 still works.Verification
npx -y pnpm@11 install→ lockfile unchanged, stilllockfileVersion: '9.0'npx -y pnpm@11 i --frozen-lockfile→ succeedspnpm i --frozen-lockfilewith pnpm 10.33.0 → succeedsjs-yaml@4.1.1orbrace-expansion@1.1.14in the lockfilepnpm run lint→ 0 errors🤖 Generated with Claude Code
https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw