feat(harness): forward-compat with engine.io WS packing + dive lever - #106
Merged
Conversation
ether/etherpad#7756 lever 8 prototype, harness side. Patches the engine.io-client transport prototype to recognise WebSocket frames that carry multiple engine.io packets joined by the record separator (\\x1e, U+001E) — the same wire format the polling transport already uses, now usable on WS when the server sets settings.enginePacking. A single-packet frame never legitimately contains the separator (engine.io packet type bytes are '0'-'6' or empty for binary, and JSON escapes raw \\x1e to ``), so the discriminator is safe: legacy servers send single-packet frames and the patch falls through to the original onData path. Patches the pnpm-store path of engine.io-client@6.6.4 directly so we touch the same module instance the bundled socket.io-client uses (pnpm symlinks resolve to one module object). Idempotent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ether/etherpad#7756 lever 8. Sets settings.enginePacking=true via sed-append so engine.io's WebSocket transport coalesces multi-packet flushes into one payload-encoded frame (matching the polling transport's wire format). Requires core_ref to include feat/engine-io-ws-packing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes for ether/etherpad#7756 lever 8 / ether/etherpad#7772:
engine.io-client patch —
src/sim/engine-packing-client-patch.tsmonkey-patches the engine.io-client Transport prototype soonDatadetects payload-encoded frames (\x1erecord separator) and routes throughdecodePayload. Single-packet frames keep the legacy path. Always-on; the separator is a safe discriminator (engine.io packet type bytes are '0'-'6' or empty for binary, JSON escapes raw\x1eto\u001e). Patches the pnpm-store path so all socket.io-client instances share the patched prototype.engine-packingmatrix entry in.github/workflows/scaling-dive.yml— setssettings.enginePacking: trueand runs the dive against the SUT. Requirescore_ref=feat/engine-io-ws-packing.48 tests still green. Build clean.