IE8.0 stops while loading pad [ad-hoc solution: IE7+ users must ENABLE native XMLHTTP support]

[Wikinaut]

IE 8.0 stops while loading pad (Chrome and Firefox do work). Here my analysis ( minify=false ):
Same output with jQuery 1.7 and 1.6.2

Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C)
Zeitstempel: Sun, 27 Nov 2011 08:49:16 UTC

Meldung: 'navigator.userAgent' ist Null oder kein Objekt
Zeile: 82
Zeichen: 1
Code: 0
URI: /static/js/ace2_common.js

Meldung: 'browser.mozilla' ist Null oder kein Objekt
Zeile: 5251
Zeichen: 3
Code: 0
URI: /static/js/ace2_inner.js

Meldung: 'browser.safari' ist Null oder kein Objekt
Zeile: 5609
Zeichen: 5
Code: 0
URI: /static/js/ace2_inner.js

[JohnMcLear]

Is this from when pita tried to fix the IE enter bug?

-----Original Message-----
From: Wikinaut [mailto:reply@reply.github.com]
Sent: 27 November 2011 08:55
To: John McLear
Subject: [etherpad-lite] IE8.0 stops while loading pad (Chrome and FF are okay) (#245)

IE 8.0 stops while loading pad (Chrome and Firefox do work). Here my analysis ( minify=false ):

Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C)
Zeitstempel: Sun, 27 Nov 2011 08:49:16 UTC

Meldung: 'navigator.userAgent' ist Null oder kein Objekt
Zeile: 82
Zeichen: 1
Code: 0
URI: /static/js/ace2_common.js

Meldung: 'browser.mozilla' ist Null oder kein Objekt
Zeile: 5251
Zeichen: 3
Code: 0
URI: /static/js/ace2_inner.js

Meldung: 'browser.safari' ist Null oder kein Objekt
Zeile: 5609
Zeichen: 5
Code: 0
URI: /static/js/ace2_inner.js

---

Reply to this email directly or view it on GitHub:
https://github.com/Pita/etherpad-lite/issues/245
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[Wikinaut]

It is in this version Wikinaut@ab4050b (just again merged with upstream/master)

[Wikinaut]

Reopened. The problem is apparent in the current upstream version.

[Pita]

Why did you reopen it?

[Wikinaut]

Reopened. I made a fresh checkout (clone): the problem is apparent in the current upstream version.

[Wikinaut]

Reopened. I made a fresh checkout (clone): the problem is apparent in the current upstream version.

[Pita]

@Wikinaut http://einfachjabber.de/jabber

[JohnMcLear]

Yerp, due to 77 in ace2_common, from the API only patch:

if (typeof exports !== "undefined")
{
// var navigator = {userAgent: "node-js"};
}
// Figure out what browser is being used (stolen from jquery 1.2.1)

breaks IE8 as Pita said.

Confirmed by commenting out teh line var navigator = {userAgent: "node-js"};

[JohnMcLear]

@Pita I assume you contacted the author of the bug?

[lorenzogil]

@johnyma22 yes, @Pita contacted me. I'll look into this today. I wrote the user-agent modification for the setHTML feature.

[lorenzogil]

Fixed with this changeset Yaco-Sistemas@c23017e

[soul9]

I can confirm that lorenzogil's patch fixes the issue in all cases I have encountered (older firefoxes would also freeze on "Loading....")

[Pita]

I applied @lorenzogil 's patch. Should be fixed now