Can locales fall back to English when a specific translation isn't available?

[ferrlen]

Suggestion: Could Etherpad be changed so that, when a chosen pad language lacks a translation, it falls back to English (or to any other language already present in the locales folder) by default?

Some plugins don't provide translations for every language. For example, using pt-br currently prevents ep_bookmarks from displaying text on the bookmark button. There are other, more severe, cases, but that one came to mind. I think it'd be much better to display English text rather than no text at all.

[JohnMcLear]

Afaik it does do that in core.. I think this is a per plugin issue but it could be we can fix this in the ep_plugin_helper and port more plugins logic over to that (I'm doing that right now for ether/ep*:pad_settings)

Can you find any other examples or just ep_bookmarks?

[JohnMcLear]

#7698 brings in core support then ep_plugin_helpers brings in easier support for plugins then plugins can migrate like this: https://github.com/ether/ep_table_of_contents/pull/191/changes#diff-a63f4fd648a0b1c18e0a8b6a2f3862226720add8985b4ea11a97ea677ac88deeR23

This has the added advantage of that if you want to auto-enable/force a setting on all pad users then the original author of the pad has that "power".

I'd suggest opening a bug report with ep_bookmarks to do the migration or send a PR to that plugin :)

[ferrlen]

Thanks a lot, @JohnMcLear , for implementing this so quickly! I'll make a PR there when I get some free time.

I found another issue, but this time it had to do with not specifying the localization key in the different locale json files.

In Etherpad's src/locales, the index.generateNewPad key seems to be missing in most (all?) locales except en.json ( https://github.com/ether/etherpad/blob/develop/src/locales/en.json ). Hence, when my language is set to something else, like pt-br, the button won't show any text, since the key is missing.

EDIT: Given that in both cases the missing text is on a button, I'm starting to think it's only related to buttons. Because you're right, the rest of the text for ep_bookmarks seems to be there in English (given it doesn't have a locale json file for Portuguese)