Saved revisions are not displayed as markers in the timeslider

[distinguished-penguin]

Describe the bug

Saved revisions are not displayed as markers in the timeslider.

After clicking the Save Revision button, the revision appears to be saved successfully.
The timeslider can be opened and document history can be navigated normally, however no markers indicating saved revisions are shown on the timeline.

To Reproduce

1. Create a new pad.
2. Add some content.
3. Click Save Revision.
4. Make additional edits.
5. Click Save Revision again.
6. Open the timeslider.
7. Observe that no saved revision markers are visible on the timeline.

Expected behavior

Saved revisions should be displayed as markers in the timeslider, allowing users to quickly navigate to explicitly saved points in time.

Screenshots

Response after clicking the "Save revision" button:

Time-slider:

Server (please complete the following information):

• Etherpad version: 3.3.1
• OS: RHEL 9
• Node.js version (node --version): Official Docker Image
• npm version (npm --version): Official Docker Image
• Is the server free of plugins: yes
• Are you using any abstraction IE docker: yes (docker)

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Firefox
• Version: 151.0.2 (64-bit)

Additional context

The issue was reproduced after upgrading to Etherpad 3.3.1.
As I did not previously ran 3.3.0 it might be a regression bug, which started to appear in 3.3.0.

The Save Revision button is available and appears to function, but no corresponding markers are shown in the timeslider. The timeslider itself works and allows navigation through document history.

It is unclear whether this is a regression, an intended behavior change, or a separate issue affecting the display of saved revisions.

[JohnMcLear]

Yea this is not intentional. Looks like a test has failed and didn't report this as broken.. Looking into it..

[JohnMcLear]

Thanks for creating this issue btw, I would have missed this1

[JohnMcLear]

When I moved timeslider to in the pad I forgot to port each test from /timeslider to the "in pad" version.

Fixed rev stars and tests to prevent regression..

Should be merged in 15 mins or so

[distinguished-penguin]

@JohnMcLear thank you very much for responding and fixing this so promptly!

[JohnMcLear]

@distinguished-penguin all good buddy, thanks for reporting it so quickly and clearly!