Skip to content
This repository was archived by the owner on Dec 31, 2024. It is now read-only.

Left sided string, fixing inconsistency with Alethzero(#5) - #21

Closed
o-jasper wants to merge 2 commits into
ethereum:masterfrom
o-jasper:left-sided-string
Closed

o-jasper wants to merge 2 commits into
ethereum:masterfrom
o-jasper:left-sided-string

Conversation

@o-jasper

Copy link
Copy Markdown
Contributor

Right-padding instead of left padding.. Looks like the pyethereum tester has a string conversion too, so that'd need a little change too.

Oh, looks like serpent.encode_data and serpent.decode_data need some modification aswel. Although maybe the tester itself should expose some such. I tested it with my own encode and decoder on some of my projects.(1, 2)

Develop branch is old, so i sent it to master.

@o-jasper o-jasper changed the title Left sided string Left sided string, fixing inconsistency with Alethzero Nov 12, 2014
@o-jasper o-jasper changed the title Left sided string, fixing inconsistency with Alethzero Left sided string, fixing inconsistency with Alethzero(#5) Nov 12, 2014
@o-jasper

Copy link
Copy Markdown
Contributor Author

Reading serpent.encode_data, i dont think it does with strings what i thought it did. (For linking issues together: #5 and #16.) Since python seems to deal with 32-byte integers, anyway, it would make sense to interpret strings as strings? You can already input an adress as 0x... number. I am not sure what the 40-byte string input is supposed to do.

o-jasper added a commit to BitVote/bitvote that referenced this pull request Nov 12, 2014
Removed reference to `launch_addr_input`.
made the test work with ethereum/serpent#21, seems like voting works with that now
@o-jasper o-jasper closed this by deleting the head repository Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant