feat(genres): add canonical genre storage, assignment, and catalog feeds - #153
Draft
phildenhoff wants to merge 1 commit into
Draft
phildenhoff wants to merge 1 commit into
phildenhoff wants to merge 1 commit into
Conversation
phildenhoff
added this pull request to stack #156
September 18, 2026 00:24
This was referenced Sep 18, 2026
This was referenced Sep 18, 2026
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-9-genres
branch
from
September 18, 2026 03:16
641f9c7 to
166d48d
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-9-genres
branch
from
September 18, 2026 17:11
166d48d to
c7faeb1
Compare
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-9-genres
branch
from
September 18, 2026 18:26
c7faeb1 to
b3ea01c
Compare
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
opds-9-genres
branch
from
September 18, 2026 22:05
b3ea01c to
9548ff7
Compare
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
feat(opds): serve canonical genre feeds
phildenhoff
force-pushed
the
opds-9-genres
branch
from
September 19, 2026 06:50
9548ff7 to
d4edd24
Compare
libcalibre Test Coverage ReportOverall coverage: 84.01% Coverage breakdown available in the artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Calibre tags are freeform, which makes them a noisy, unstable basis for a genre facet. Citadel wants a small canonical genre list — distinct from tags, and distinct from whatever a metadata provider happens to file under "subject" — that books can be assigned and readers can browse (ADR 0003).
What changed
citadel_genrescustom column, created on demand;set_book_genres/add_book_genresnormalize names,list_genresreturns genres with book counts, and book queries can filter by a resolved genre.hardcover:genre) and MARC 655 genre/form terms (marc:655). Open Library subjects and other MARC 6XX fields stay suggestions and are never silently promoted to genres.One behavioral note worth knowing: the facet stays empty until someone assigns a genre, because that first assignment is what creates the column.
Validation: the stack tip runs 62 citadel-opds tests + 348 workspace tests, all green.
Stack: #146 → #147 → #148 → #149 → #150 → #151 → #152 → #153 (this) → #154 → #155