Skip to content

Add more test cases for submitBlocksToDA in manager_test.go #1530

Description

@Manav-Aggarwal
This needs an update to testing. 

Test cases I can think of that we should understand how they execute. 
Assuming starting with Blocks a b c
1. happy case, all are submitted on first round
2. a and b are submitted first because including c triggers size limit. C is then submitted on second round.
3. C is too big on it's own, never submitted but a and b are
4. C has a marshal issue. A and b should still be submitted ( I think this case currently isn't possible with the code based on `SubmitBlocks`)
5. A is too big on its own 
6. A has a marshal issue

for cases 5 and 6, what should be the desired outcome? Do we never submit any blocks if the current next block is bad? Based on `SubmitBlocks` that appears to be the case.

_Originally posted by @MSevey in https://github.com/rollkit/rollkit/pull/1471#pullrequestreview-1832928038_

Note that test cases 1, 2, 3 here are added and test cases 4, 5, 6 need to be added.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T:testingRelated to testing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions