refactor: bump go header and complete rollback command - #2618
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
julienrbrt
commented
Sep 2, 2025
Wondertan
reviewed
Sep 3, 2025
Wondertan
reviewed
Sep 3, 2025
julienrbrt
marked this pull request as ready for review
September 4, 2025 19:27
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
- Coverage 71.07% 71.06% -0.01%
==========================================
Files 73 73
Lines 7644 7638 -6
==========================================
- Hits 5433 5428 -5
Misses 1756 1756
+ Partials 455 454 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tac0turtle
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to bump the go-header (https://github.com/celestiaorg/go-header/releases/tag/v0.7.0) to access the DeleteTo method, which is required when we want to rollback a chain.
The header and data sync goheader stores should be rolled back as well.
ref: evstack/ev-abci#236, https://github.com/ignite/apps/pull/223/files