Skip to content

refactor: bump go header and complete rollback command - #2618

Merged
tac0turtle merged 14 commits into
mainfrom
julien/goheader
Sep 5, 2025
Merged

refactor: bump go header and complete rollback command#2618
tac0turtle merged 14 commits into
mainfrom
julien/goheader

Conversation

@julienrbrt

@julienrbrt julienrbrt commented Sep 2, 2025

Copy link
Copy Markdown
Member

We need to bump the go-header (https://github.com/celestiaorg/go-header/releases/tag/v0.7.0) to access the DeleteTo method, which is required when we want to rollback a chain.
The header and data sync goheader stores should be rolled back as well.

ref: evstack/ev-abci#236, https://github.com/ignite/apps/pull/223/files

@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedSep 4, 2025, 8:41 PM

Comment thread pkg/sync/sync_service.go Outdated
Comment thread pkg/sync/sync_service.go Outdated
Comment thread pkg/sync/sync_service.go Outdated
@julienrbrt
julienrbrt marked this pull request as ready for review September 4, 2025 19:27
@codecov

codecov Bot commented Sep 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.69231% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.06%. Comparing base (6d93f12) to head (a551ba5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sync/sync_service.go 27.69% 39 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
- Coverage   71.07%   71.06%   -0.01%     
==========================================
  Files          73       73              
  Lines        7644     7638       -6     
==========================================
- Hits         5433     5428       -5     
  Misses       1756     1756              
+ Partials      455      454       -1     
Flag Coverage Δ
combined 71.06% <27.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tac0turtle
tac0turtle merged commit c5d00c5 into main Sep 5, 2025
28 of 31 checks passed
@tac0turtle
tac0turtle deleted the julien/goheader branch September 5, 2025 09:23
@github-project-automation github-project-automation Bot moved this to Done in Evolve Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants