Skip to content

👔 app: update benefits - #1078

Merged
cruzdanilo merged 1 commit into
mainfrom
benefits
Jun 5, 2026
Merged

👔 app: update benefits#1078
cruzdanilo merged 1 commit into
mainfrom
benefits

Conversation

@franm91

@franm91 franm91 commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

Release Notes

  • Refactor

    • Simplified the benefits experience by removing the Pax benefit option.
    • Removed animated pagination indicators from the benefits carousel for a cleaner interface.
  • Chores

    • Updated promotional period timeline: 0% interest promotion now runs through June with interest reimbursed in early July (previously May/early June).
    • Extended promo expiration date to July 1, 2026.

@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ce6ad88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@franm91, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 20f245f0-4cf2-4505-bd89-73ebb1e34b6a

📥 Commits

Reviewing files that changed from the base of the PR and between 38a0f0b and ce6ad88.

📒 Files selected for processing (10)
  • .changeset/big-worms-remain.md
  • .maestro/subflows/assertBenefits.yaml
  • src/components/benefits/BenefitSheet.tsx
  • src/components/benefits/BenefitsSection.tsx
  • src/components/home/InstallmentsSheet.tsx
  • src/components/home/PromoSheet.tsx
  • src/i18n/es-AR.json
  • src/i18n/es.json
  • src/i18n/pt.json
  • src/utils/promo.ts

Walkthrough

This PR removes the Pax benefit feature and its associated UI components (clipboard copying, ID fetching, animated pagination), simplifies the benefits carousel, and updates promotional timeline strings from May/June to June/July across components and translations.

Changes

Benefits UI Cleanup & Promo Timeline Update

Layer / File(s) Summary
Pax benefit removal
src/components/benefits/BenefitSheet.tsx, src/components/benefits/BenefitsSection.tsx, src/i18n/es-AR.json, src/i18n/pt.json
Removes Pax Assistance imports and clipboard/toast/query logic from BenefitSheet, removes Pax from the benefits array, and removes Pax-related translation keys and unused "Benefits"/"Failed to load" entries across i18n files.
Pagination UI simplification
src/components/benefits/BenefitsSection.tsx
Removes animated pagination dot system (Reanimated progress tracking, state management, and Carousel onProgressChange handler) while maintaining core carousel and benefit sheet navigation.
Promo timeline update
src/utils/promo.ts, src/components/home/InstallmentsSheet.tsx, src/components/home/PromoSheet.tsx, src/i18n/es-AR.json, src/i18n/es.json, src/i18n/pt.json
Updates PROMO expiration to July 1, revises UI text to state promotions are "through June" with reimbursement "in early July", and updates Spanish and Portuguese translated promo strings accordingly.
Release metadata
.changeset/big-worms-remain.md
Adds Changeset entry declaring a patch version bump for @exactly/mobile.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • exactly/exa#634: The main PR modifies the benefits components introduced in #634—removing the Pax-specific BenefitSheet fetching/copying logic and the Pax benefit entry from BenefitsSection that #634 added.
  • exactly/exa#701: Both PRs touch src/components/benefits/BenefitsSection.tsx pagination logic—💫 improve carousel transitions #701 adds scroll-synced animated pagination dots, while the main PR removes that entire animated pagination dot system.
  • exactly/exa#1014: Both PRs touch the Pax benefit UI path in BenefitSheet—🐛 app: misc fixes #1014 tweaks styling while the main PR removes the entire Pax-specific copy/ID flow.

Suggested reviewers

  • dieguezguille
  • cruzdanilo
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '👔 app: update benefits' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific changes made. Consider a more specific title that reflects the main changes, such as: '👔 Remove Pax benefit and update promo dates to July' or '👔 Remove Pax integration and update promotional timelines'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch benefits
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch benefits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Pax Assistance benefit from the mobile application, including its copy-to-clipboard logic, related translations, and the pagination dots in the benefits carousel. It also extends the 0% interest promo from May to June (with reimbursement in early July) across various UI sheets, translation files, and the promo utility. The reviewer suggests updating the PROMO.id in src/utils/promo.ts to reflect the June extension, as keeping the old ID might prevent users who previously dismissed the May promo from seeing the June details if local storage or analytics keys off this ID.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/utils/promo.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38a0f0b8ac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/utils/promo.ts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 02fc0d75-b9d4-449e-8913-72e7f72cdfae

📥 Commits

Reviewing files that changed from the base of the PR and between 91c5ca3 and 38a0f0b.

📒 Files selected for processing (9)
  • .changeset/big-worms-remain.md
  • src/components/benefits/BenefitSheet.tsx
  • src/components/benefits/BenefitsSection.tsx
  • src/components/home/InstallmentsSheet.tsx
  • src/components/home/PromoSheet.tsx
  • src/i18n/es-AR.json
  • src/i18n/es.json
  • src/i18n/pt.json
  • src/utils/promo.ts

Comment thread src/components/home/InstallmentsSheet.tsx Outdated
Comment thread src/utils/promo.ts
@sentry

sentry Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (91c5ca3) to head (ce6ad88).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/components/benefits/BenefitSheet.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
- Coverage   74.33%   74.26%   -0.07%     
==========================================
  Files         243      243              
  Lines       11239    11213      -26     
  Branches     3822     3806      -16     
==========================================
- Hits         8354     8327      -27     
- Misses       2561     2562       +1     
  Partials      324      324              
Flag Coverage Δ
e2e 74.26% <87.50%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo
cruzdanilo merged commit ce6ad88 into main Jun 5, 2026
12 of 14 checks passed
@cruzdanilo
cruzdanilo deleted the benefits branch June 5, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants