Skip to content

✨ app: prompt bridge future requirements on account details - #1121

Merged
cruzdanilo merged 1 commit into
mainfrom
requirements
Jun 29, 2026
Merged

✨ app: prompt bridge future requirements on account details#1121
cruzdanilo merged 1 commit into
mainfrom
requirements

Conversation

@dieguezguille

@dieguezguille dieguezguille commented Jun 29, 2026

Copy link
Copy Markdown
Member

closes #1104

Summary by CodeRabbit

  • New Features

    • Added an in-app verification flow for Bridge accounts when more information is required.
    • Users now see a prompt with a localized date and can continue directly to verification.
    • Added Spanish and Portuguese translations for the new account-active message.
  • Bug Fixes

    • Improved the verification experience by returning users to the main screen after completion or errors and refreshing available provider data.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c19acf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@cruzdanilo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 08163443-8eac-4cf5-b56f-f6c47cf442ad

📥 Commits

Reviewing files that changed from the base of the PR and between e8195cf and c19acf3.

📒 Files selected for processing (4)
  • .changeset/brave-otters-gather.md
  • src/components/add-funds/Ramp.tsx
  • src/i18n/es.json
  • src/i18n/pt.json

Walkthrough

Adds a Bridge futureRequirement verification flow in Ramp.tsx: a new verifying state, a derived localized deadline date, an InfoAlert prompt, and an in-app RampWebView with redirect/error handling that invalidates the ["ramp","providers"] query. Spanish and Portuguese translations for the deadline message are also added.

Bridge Future Requirement Verification

Layer / File(s) Summary
State, derived requirement, and imports
src/components/add-funds/Ramp.tsx
Adds verifying state (initialized to false), derives requirement from providers.bridge.futureRequirement, computes a memoized localized date via parseISO, and adds imports for parseISO, RampWebView, and queryClient.
Verification webview flow and InfoAlert
src/components/add-funds/Ramp.tsx
When verifying is true, renders RampWebView pointing to requirement.url; on redirect clears verifying and invalidates ["ramp","providers"]; on error clears verifying and shows a toast. Adds a conditional InfoAlert that sets verifying to true when the user taps "Get started".
Translations and changeset
src/i18n/es.json, src/i18n/pt.json, .changeset/brave-otters-gather.md
Adds Spanish and Portuguese translations for the "We need more information to keep your account active after {{date}}." key, and a patch changeset entry.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Ramp
  participant RampWebView
  participant QueryClient

  User->>Ramp: Taps "Get started" on InfoAlert
  Ramp->>Ramp: setVerifying(true)
  Ramp->>RampWebView: Render with requirement.url
  alt Redirect success
    RampWebView->>Ramp: onRedirect
    Ramp->>QueryClient: invalidateQueries(["ramp","providers"])
    Ramp->>Ramp: setVerifying(false)
  else Error
    RampWebView->>Ramp: onError
    Ramp->>Ramp: setVerifying(false), show toast
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • exactly/exa#735: Invalidates the ["ramp","providers"] query after ramp-related webview actions, the same cache key this PR invalidates on redirect.
  • exactly/exa#973: Implements the RampWebView component and redirect/error handling pattern that this PR reuses for the Bridge verification flow.

Suggested reviewers

  • cruzdanilo
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The changes add a Bridge-specific prompt and deadline copy, but the summary does not confirm EEA-only targeting or an external-link CTA as required by #1104. Verify the banner is restricted to EEA Bridge users needing extra info and that the CTA opens the required external submission link.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR's main change: prompting Bridge users about future account requirements.
Out of Scope Changes check ✅ Passed The changes appear focused on the Bridge requirements prompt and related translations/release note, with no clear unrelated scope.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch requirements
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch requirements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a verification flow in the Ramp component to handle future account requirements for the Bridge provider. It introduces a verification state, renders a web view for the requirement URL, and displays an information alert with localized messages. The review feedback suggests simplifying the extraction of the requirement object and optimizing the useMemo dependency array by using requirement?.date instead of the entire object to prevent unnecessary recalculations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/add-funds/Ramp.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: af84eefd-17dc-42a7-9a23-cc58edd6709c

📥 Commits

Reviewing files that changed from the base of the PR and between 371acd9 and e8195cf.

📒 Files selected for processing (4)
  • .changeset/brave-otters-gather.md
  • src/components/add-funds/Ramp.tsx
  • src/i18n/es.json
  • src/i18n/pt.json

Comment thread src/components/add-funds/Ramp.tsx
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.26%. Comparing base (698f903) to head (e8c117f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   72.27%   72.26%   -0.02%     
==========================================
  Files         248      248              
  Lines        9827     9827              
  Branches     3162     3162              
==========================================
- Hits         7102     7101       -1     
  Misses       2463     2463              
- Partials      262      263       +1     
Flag Coverage Δ
e2e 72.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo
cruzdanilo merged commit c19acf3 into main Jun 29, 2026
2 of 4 checks passed
@cruzdanilo
cruzdanilo deleted the requirements branch June 29, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: banner for eea users bridge

2 participants