Skip to content

🐛 app: misc fixes - #1126

Merged
cruzdanilo merged 3 commits into
mainfrom
fixes
Jul 1, 2026
Merged

🐛 app: misc fixes#1126
cruzdanilo merged 3 commits into
mainfrom
fixes

Conversation

@dieguezguille

@dieguezguille dieguezguille commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Refreshed the onboarding authentication carousel: updated the headline and removed an extra QR-code slide.
    • Add-funds and supported-asset experiences now use a market-driven supported asset list, with skeleton placeholders shown while loading.
  • Bug Fixes
    • Improved asset selection and asset chips on address-copy flows to better match current availability.
    • Removed outdated “coming soon” messaging and updated localized onboarding text to match the new carousel copy.

@dieguezguille dieguezguille self-assigned this Jul 1, 2026
@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ed5f97f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b6cb1661-811e-407f-bcd4-73128a3305b7

📥 Commits

Reviewing files that changed from the base of the PR and between c17b9af and ed5f97f.

📒 Files selected for processing (11)
  • .changeset/little-loops-shop.md
  • .changeset/strong-vans-build.md
  • .changeset/swift-otters-jump.md
  • src/components/add-funds/AddCrypto.tsx
  • src/components/add-funds/SupportedAssetsSheet.tsx
  • src/components/auth/Auth.tsx
  • src/components/shared/CopyAddressSheet.tsx
  • src/i18n/es.json
  • src/i18n/pt.json
  • src/utils/useMarkets.ts
  • src/utils/usePortfolio.ts

Walkthrough

This PR removes the auth carousel’s disabled QR-payments slide and “COMING SOON” state, updates related translations, and changes supported-asset lists to derive from useMarkets across add-funds and portfolio flows.

Changes

Supported Assets Sourced from Markets

Layer / File(s) Summary
useMarkets computes supportedAssets
src/utils/useMarkets.ts
Hook now stores markets locally and derives a memoized supportedAssets list (excluding USDC.e, DAI, WETH; forcing ETH), returned from the hook.
usePortfolio consumes supportedAssets
src/utils/usePortfolio.ts
protocolSymbols now comes directly from useMarkets's supportedAssets instead of a locally computed value.
AddCrypto uses market-sourced assets
src/components/add-funds/AddCrypto.tsx
Non-bridge asset list now uses supportedAssets from useMarkets, and shows skeleton icons while pending.
SupportedAssetsSheet pending state and Chip UI
src/components/add-funds/SupportedAssetsSheet.tsx
Sources supportedAssets from useMarkets, shows skeleton chips while pending, and introduces a reusable Chip component for asset rows.
CopyAddressSheet uses market-sourced assets
src/components/shared/CopyAddressSheet.tsx
Replaces assetLogos-based filtering with supportedAssets from useMarkets, with a pending skeleton state.
Changeset for supported-assets fix
.changeset/swift-otters-jump.md
Records a patch changeset documenting sourcing supported assets from markets.

Auth Carousel Simplification

Layer / File(s) Summary
Auth.tsx page type and carousel content changes
src/components/auth/Auth.tsx
Removes disabled?: boolean from Page, removes the "COMING SOON" badge render, drops the QR-code page and its SVG imports, and updates the first page's title to "Introducing the first onchain credit card".
Locale updates for auth carousel copy
src/i18n/es.json, src/i18n/pt.json
Removes "COMING SOON" translation entries and updates the onboarding title key/value to reference the "onchain credit card" in both locales.
Changesets for auth carousel changes
.changeset/little-loops-shop.md, .changeset/strong-vans-build.md
Records patch changesets for the auth carousel copy update and removal of the QR payments slide.

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

  • exactly/exa#701: Both PRs modify src/components/auth/Auth.tsx's carousel implementation, overlapping in carousel page/UI behavior.

Suggested labels: bug

Suggested reviewers: franm91, cruzdanilo

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is generic and does not clearly describe the main changes in the PR. Use a specific title that names the primary change, such as updating auth carousel copy and supported assets handling.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how supported assets are sourced by retrieving them dynamically from the useMarkets hook instead of using a hardcoded list. It also updates the authentication carousel by removing the QR payments slide, removing the "COMING SOON" badge, and updating the copy for the onchain card to specify it as a credit card. The review feedback highlights potential layout shifts in AddCrypto.tsx and CopyAddressSheet.tsx when useMarkets() is loading and supportedAssets is empty, suggesting that isPending should be destructured and used to handle the loading states.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/add-funds/AddCrypto.tsx Outdated
Comment thread src/components/shared/CopyAddressSheet.tsx Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: facbc88a-c544-469b-9fef-0b0783164bd4

📥 Commits

Reviewing files that changed from the base of the PR and between 5dda070 and c17b9af.

⛔ Files ignored due to path filters (2)
  • src/assets/images/qr-code-blob.svg is excluded by !**/*.svg
  • src/assets/images/qr-code.svg is excluded by !**/*.svg
📒 Files selected for processing (11)
  • .changeset/little-loops-shop.md
  • .changeset/strong-vans-build.md
  • .changeset/swift-otters-jump.md
  • src/components/add-funds/AddCrypto.tsx
  • src/components/add-funds/SupportedAssetsSheet.tsx
  • src/components/auth/Auth.tsx
  • src/components/shared/CopyAddressSheet.tsx
  • src/i18n/es.json
  • src/i18n/pt.json
  • src/utils/useMarkets.ts
  • src/utils/usePortfolio.ts

Comment thread src/components/add-funds/AddCrypto.tsx
Comment thread src/components/shared/CopyAddressSheet.tsx
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.46%. Comparing base (39ce9d6) to head (ed5f97f).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   72.44%   72.46%   +0.01%     
==========================================
  Files         249      249              
  Lines       10088    10091       +3     
  Branches     3273     3274       +1     
==========================================
+ Hits         7308     7312       +4     
+ Misses       2501     2500       -1     
  Partials      279      279              
Flag Coverage Δ
e2e 72.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo
cruzdanilo merged commit ed5f97f into main Jul 1, 2026
14 checks passed
@cruzdanilo
cruzdanilo deleted the fixes branch July 1, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants