🐛 app: misc fixes - #1126
Conversation
🦋 Changeset detectedLatest commit: ed5f97f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (11)
WalkthroughThis PR removes the auth carousel’s disabled QR-payments slide and “COMING SOON” state, updates related translations, and changes supported-asset lists to derive from ChangesSupported Assets Sourced from Markets
Auth Carousel Simplification
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request refactors how supported assets are sourced by retrieving them dynamically from the useMarkets hook instead of using a hardcoded list. It also updates the authentication carousel by removing the QR payments slide, removing the "COMING SOON" badge, and updating the copy for the onchain card to specify it as a credit card. The review feedback highlights potential layout shifts in AddCrypto.tsx and CopyAddressSheet.tsx when useMarkets() is loading and supportedAssets is empty, suggesting that isPending should be destructured and used to handle the loading states.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: facbc88a-c544-469b-9fef-0b0783164bd4
⛔ Files ignored due to path filters (2)
src/assets/images/qr-code-blob.svgis excluded by!**/*.svgsrc/assets/images/qr-code.svgis excluded by!**/*.svg
📒 Files selected for processing (11)
.changeset/little-loops-shop.md.changeset/strong-vans-build.md.changeset/swift-otters-jump.mdsrc/components/add-funds/AddCrypto.tsxsrc/components/add-funds/SupportedAssetsSheet.tsxsrc/components/auth/Auth.tsxsrc/components/shared/CopyAddressSheet.tsxsrc/i18n/es.jsonsrc/i18n/pt.jsonsrc/utils/useMarkets.tssrc/utils/usePortfolio.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
+ Coverage 72.44% 72.46% +0.01%
==========================================
Files 249 249
Lines 10088 10091 +3
Branches 3273 3274 +1
==========================================
+ Hits 7308 7312 +4
+ Misses 2501 2500 -1
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit