Skip to content

fix: switch to kernel_manager_class#725

Open
flying-sheep wants to merge 1 commit into
executablebooks:mainfrom
flying-sheep:kmc
Open

fix: switch to kernel_manager_class#725
flying-sheep wants to merge 1 commit into
executablebooks:mainfrom
flying-sheep:kmc

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Sorry for that. Trying to use the new feature, I realized that jupyter_cache doesn’t have a way to close the kernel client and neither does nbclient’s execute, seems like they don’t really test that API.

This variant works, since it goes down the owns_kc path and therefore shuts down everything nicely.

This time I actually checked if it works as expected: flying-sheep/sphinx-exec-jupyter#33

@bsipocz

bsipocz commented Jul 20, 2026

Copy link
Copy Markdown
Member

Thanks @flying-sheep for the follow-up. I'm pretty sure the rtd failure is unrelated but I'll have to have a closer code when I'm back at the keyboard before merging this.

@flying-sheep

Copy link
Copy Markdown
Contributor Author

Thank you! Again, very sorry, I didn’t consider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants