fix: switch to kernel_manager_class#725
Open
flying-sheep wants to merge 1 commit into
Open
Conversation
Member
|
Thanks @flying-sheep for the follow-up. I'm pretty sure the rtd failure is unrelated but I'll have to have a closer code when I'm back at the keyboard before merging this. |
Contributor
Author
|
Thank you! Again, very sorry, I didn’t consider this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for that. Trying to use the new feature, I realized that
jupyter_cachedoesn’t have a way to close the kernel client and neither does nbclient’sexecute, seems like they don’t really test that API.This variant works, since it goes down the
owns_kcpath and therefore shuts down everything nicely.This time I actually checked if it works as expected: flying-sheep/sphinx-exec-jupyter#33