Fix typos in Readme#19
Merged
Merged
Conversation
Member
Ahh. That's why I faced this - #15 😄 |
Contributor
Author
|
You’re welcome. @SleeplessByte added a user friendly message that logged to the console notifying me that the module wasn’t found so it made it easy for me to see the issue. I’m pretty sure he added that in response to your issue. |
SleeplessByte
approved these changes
May 31, 2019
Member
|
Thank you! This is perfect ❤️ |
SleeplessByte
added a commit
to exercism/typescript-analyzer
that referenced
this pull request
Jun 4, 2019
* Create CODE_OF_CONDUCT (originally @SleeplessByte exercism/javascript-analyzer#5) * Add dockerfile for automated mentoring support (originally @depsir exercism/javascript-analyzer#12) * Initial smoke for usage of jest (originally: @SleeplessByte exercism/javascript-analyzer#17) * Apply design and proper interface and structure (originally: @SleeplessByte exercism/javascript-analyzer#18) * Fixes issues in the README.md (originally: @zeckdude exercism/javascript-analyzer#19)
SleeplessByte
added a commit
to exercism/typescript-analyzer
that referenced
this pull request
Jun 4, 2019
* Create CODE_OF_CONDUCT (originally @SleeplessByte exercism/javascript-analyzer#5) * Add dockerfile for automated mentoring support (originally @depsir exercism/javascript-analyzer#12) * Initial smoke for usage of jest (originally: @SleeplessByte exercism/javascript-analyzer#17) * Apply design and proper interface and structure (originally: @SleeplessByte exercism/javascript-analyzer#18) * Fixes issues in the README.md (originally: @zeckdude exercism/javascript-analyzer#19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a few issues in the README:
./bin/analyze.shexample is incorrect./bin/analyze.shexample should be pointing to the folder instead of the actual solution--debugand--consoleflags need to be in the command if people want to see the output in the terminal, so I think it's helpful to have them in the example