fix: Remove the legacy digest stubs of the processes notification providers - EXO-90072 - eXIP7.3.0.22 - #494
Merged
Conversation
…viders - EXO-90072 - eXIP7.3.0.22 The makeDigest(NotificationContext, Writer) hook of AbstractTemplateBuilder is now a concrete deprecated no-op in commons-api since the new digest engine (io.meeds.commons.digest) replaced the legacy one, so the "return false" overrides in MailTemplateProvider and PushTemplateProvider are dead code. The new ProcessesDigestLinePlugin and its configuration are untouched. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
azayati
marked this pull request as ready for review
September 9, 2026 09:10
azayati
added a commit
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The three
makeDigeststub overrides ofMailTemplateProviderandPushTemplateProviderand their unused imports. No legacy digest key existed in this addon.Untouched:
ProcessesDigestLinePlugin, its Kernel declaration,getWorkById, theREQUEST_IDargument and keys.Checked
processes-servicesbuilds (online, two transitive dependencies missing offline); the 8 notification tests includingProcessesDigestLinePluginTestare green.N2 (addon, no schema, no security). 🤖 Generated with Claude Code