fix: parse JSON cookies with falsy values - #172
Open
spokodev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONCookies()only writes the parsed value back when it is truthy (if (val)), so a cookie whose JSON payload isfalse,0,nullor""is left as the rawj:-prefixed string instead of being inflated. The README states such values "will be exposed as the result ofJSON.parse".JSONCookie()already returnsundefinedonly on parse failure, so guarding onval !== undefinedpreserves the "keep the original value on invalid JSON" behaviour while correctly parsing falsy values.Refs #168.