Prefix local build image with ghcr.io/extra-org/extra to match prod - #83
Merged
Merged
Conversation
make build tagged the image extra:local, while prod releases push to ghcr.io/extra-org/extra:<tag>. The differing prefix made it unclear that the local build is the same image as prod, just a different tag. Fixes extra-org#82
Collaborator
|
Please star project and comment on the issue so i can assigned to you the issue |
AmitAvital1
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make buildtagged the local image asextra:local(Makefile:20), while prod releases push toghcr.io/${{ github.repository }}:${TAG}(i.e.ghcr.io/extra-org/extra:*). The differing prefix made it harder to tell the local build is the same image as prod, just a different tag.ghcr.io/extra-org/extra:localin the three places that reference it:Makefile,examples/starter/docker-compose.yml,examples/enterprise-knowledge-assistant/docker-compose.yml.Fixes #82
Test plan
grep -rn "extra:local"— only the newghcr.io/extra-org/extra:localreferences remain, no stragglersdocker compose -f examples/starter/docker-compose.yml config -q— parses cleanlydocker compose -f examples/enterprise-knowledge-assistant/docker-compose.yml config -q— parses cleanlymake build(would require pulling/building the whole image), but the change is a pure string substitution with no other logic touched.