Skip to content
This repository was archived by the owner on Dec 25, 2025. It is now read-only.

Split packages by node.js dependencies - #32

Merged
IzumiSy merged 1 commit into
mainfrom
split_packages_by_dependencies
Oct 16, 2024
Merged

Split packages by node.js dependencies#32
IzumiSy merged 1 commit into
mainfrom
split_packages_by_dependencies

Conversation

@IzumiSy

@IzumiSy IzumiSy commented Oct 16, 2024

Copy link
Copy Markdown
Member

Importing @fabrix-framework/graphql-config automatically imports Node.js related dependencies (e.g. node:os, node:path, ...), so this PR splits the packages by Node.js dependencies.

This is critical that the client components in Next.js app cannot import graphql-config packages due to its dependencies.

@IzumiSy IzumiSy self-assigned this Oct 16, 2024
@IzumiSy
IzumiSy force-pushed the split_packages_by_dependencies branch from 4165413 to 0a65210 Compare October 16, 2024 08:22
@IzumiSy
IzumiSy force-pushed the split_packages_by_dependencies branch from 0a65210 to 5f64084 Compare October 16, 2024 08:22
@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2024

Copy link
Copy Markdown

Open in Stackblitz

pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/chakra-ui@32
pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/graphql-config@32
pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/fabrix@32

commit: 5f64084

@IzumiSy

IzumiSy commented Oct 16, 2024

Copy link
Copy Markdown
Member Author

Confirmed this changes worked out in another private app.

@IzumiSy
IzumiSy marked this pull request as ready for review October 16, 2024 08:42
@IzumiSy
IzumiSy requested a review from a team as a code owner October 16, 2024 08:42

@toiroakr toiroakr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IzumiSy
IzumiSy merged commit a3b624c into main Oct 16, 2024
@IzumiSy
IzumiSy deleted the split_packages_by_dependencies branch October 16, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants