Skip to content
This repository was archived by the owner on Dec 25, 2025. It is now read-only.

Validation directive support - #38

Merged
IzumiSy merged 40 commits into
mainfrom
directive_validation_support
Oct 25, 2024
Merged

Validation directive support#38
IzumiSy merged 40 commits into
mainfrom
directive_validation_support

Conversation

@IzumiSy

@IzumiSy IzumiSy commented Oct 17, 2024

Copy link
Copy Markdown
Member

See #36 to know overall design for this PR.

Changes

Added constraint field in formField directive.

See newly inteface added in the changes of packages/graphql-config/src/schema/constraint.graphql

Leftovers

  • Conditional validation and field reference
    • To me these kind of validation is needed for actual usecase but a bit rather advanced and I think we can omit it from minimum requirement, so I would like to tackle on them as an another item (Conditional validation, Field reference validation)

@IzumiSy IzumiSy self-assigned this Oct 17, 2024
@IzumiSy IzumiSy linked an issue Oct 17, 2024 that may be closed by this pull request
@pkg-pr-new

pkg-pr-new Bot commented Oct 18, 2024

Copy link
Copy Markdown

Open in Stackblitz

pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/fabrix@38
pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/chakra-ui@38
pnpm add https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/graphql-config@38

commit: b64c666

@IzumiSy
IzumiSy changed the base branch from main to split_directive_files October 18, 2024 05:59
@IzumiSy
IzumiSy force-pushed the directive_validation_support branch from 261ef32 to bbf655f Compare October 18, 2024 08:24
Base automatically changed from split_directive_files to main October 18, 2024 11:20
@IzumiSy
IzumiSy marked this pull request as ready for review October 24, 2024 14:47
@IzumiSy
IzumiSy requested a review from a team as a code owner October 24, 2024 14:47
@IzumiSy
IzumiSy merged commit a1174b1 into main Oct 25, 2024
@IzumiSy
IzumiSy deleted the directive_validation_support branch October 25, 2024 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Validation (directive)

2 participants