Skip to content

Fix clippy lints introduced by Rust 1.97 - #494

Draft
kevinlewi wants to merge 1 commit into
facebook:mainfrom
kevinlewi:fix-clippy-for-kv-map
Draft

Fix clippy lints introduced by Rust 1.97#494
kevinlewi wants to merge 1 commit into
facebook:mainfrom
kevinlewi:fix-clippy-for-kv-map

Conversation

@kevinlewi

@kevinlewi kevinlewi commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

As titled

Rust 1.97 promoted two lints that now fire under CI's
`cargo clippy --all -- -D clippy::all -D warnings`, breaking main:

- `clippy::for_kv_map` in akd/src/storage/transaction.rs: iterate with
  `values_mut()` instead of destructuring an unused key.
- `clippy::question_mark` in examples/src/mysql_demo/mysql_storables.rs:
  replace a match-on-Result with `?`, matching the idiom already used a
  few lines above.

Both changes are semantics-preserving.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2026
@kevinlewi
kevinlewi marked this pull request as draft August 5, 2026 23:24
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (3ce5335) to head (81b3256).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
akd/src/storage/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   88.61%   89.31%   +0.70%     
==========================================
  Files          39       38       -1     
  Lines        9109     7442    -1667     
==========================================
- Hits         8072     6647    -1425     
+ Misses       1037      795     -242     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants