chore(workflow): add cache to workflows using actions/setup-node - #5697
Conversation
|
Hi @oscard0m! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
✔️ [V2] 🔨 Explore the source changes: 96c3c6c 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617cf0fd3e50db000765b599 😎 Browse the preview: https://deploy-preview-5697--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5697--docusaurus-2.netlify.app/ |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
This comment has been minimized.
This comment has been minimized.
slorber
left a comment
There was a problem hiding this comment.
Thanks @oscard0m
I agree we should try using that new cache feature and replace bahmutov/npm-install@v1.
However we are using yarn and we don't want to replace it with npm, so please don't replace yarn install by npm ci
Also why reformating quotes in this PR?
|
The pitfalls of script-generated PRs: you never understand what the workflow is doing😀 LGTM, if all the tests are passing let's merge and see |
Thanks for helping me moving this to the last mile |
…ebook#5697) * ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows * Use cache: yarn * Reformat Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Description
Add
cacheto workflows usingactions/setup-nodeContext
setup-nodeGitHub Action just released a new option to add cache to steps using it.You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/
🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾