Skip to content

fix(ideal-image): fix IdealImage in dev not handling ES import images properly - #5760

Merged
slorber merged 2 commits into
mainfrom
slorber/fix-ideal-image-dev
Oct 21, 2021
Merged

fix(ideal-image): fix IdealImage in dev not handling ES import images properly#5760
slorber merged 2 commits into
mainfrom
slorber/fix-ideal-image-dev

Conversation

@slorber

@slorber slorber commented Oct 21, 2021

Copy link
Copy Markdown
Collaborator

Motivation

We disabled ideal-image loader in dev (using regular file-loader instead).

The <IdealImage> comp should handle better the dev fallback

Fixes #5758

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

dogfood: site works in dev and can build

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 21, 2021
@slorber
slorber requested a review from lex111 as a code owner October 21, 2021 15:03
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 21, 2021
@netlify

netlify Bot commented Oct 21, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 0a1a2db

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61718407d8729800079dba9f

😎 Browse the preview: https://deploy-preview-5760--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5760--docusaurus-2.netlify.app/

@slorber
slorber merged commit 31ad8c4 into main Oct 21, 2021
@slorber
slorber deleted the slorber/fix-ideal-image-dev branch October 21, 2021 15:22
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IdealImage doesn't work based on docs in docusaurus.io

2 participants