Skip to content

doc: fix typo in "create a doc" - #5818

Merged
Josh-Cena merged 2 commits into
mainfrom
unknown repository
Oct 29, 2021
Merged

doc: fix typo in "create a doc"#5818
Josh-Cena merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 29, 2021

Copy link
Copy Markdown

Motivation

Micro typo.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Not needed.

Related PRs

none.

@ghost
ghost requested review from lex111 and slorber as code owners October 29, 2021 05:45
@facebook-github-bot

facebook-github-bot commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

Hi @dominikmeyersap!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify

netlify Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: fc315a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617b9813ed613100073f8c2c

😎 Browse the preview: https://deploy-preview-5818--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5818--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 29, 2021
@Josh-Cena Josh-Cena changed the title Update docs-create-doc.mdx doc: fix typo in "create a doc" Oct 29, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 29, 2021
@facebook-github-bot

facebook-github-bot commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot

This comment has been minimized.

Sign in to view
@Josh-Cena

Josh-Cena commented Oct 29, 2021

Copy link
Copy Markdown
Collaborator

👍 Thanks

@Josh-Cena
Josh-Cena merged commit ab127e5 into facebook:main Oct 29, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Dominik Meyer @Josh-Cena
doc: fix typo in "create a doc" (facebook#5818)
0c80625 
* Update docs-create-doc.mdx

* Update docs-create-doc.mdx

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lex111 lex111 Awaiting requested review from lex111
@slorber slorber Awaiting requested review from slorber slorber is a code owner

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@facebook-github-bot @Josh-Cena