Skip to content

chore: replace doc sample .pdf file by .xlsx to solve Crowdin issue - #5823

Merged
slorber merged 3 commits into
mainfrom
slorber/remove-pdf-in-doc
Oct 29, 2021
Merged

chore: replace doc sample .pdf file by .xlsx to solve Crowdin issue#5823
slorber merged 3 commits into
mainfrom
slorber/remove-pdf-in-doc

Conversation

@slorber

@slorber slorber commented Oct 29, 2021

Copy link
Copy Markdown
Collaborator

Motivation

Crowdin decided to transform pdf to html files recently and there's no way to fix our site's deploy without using the UI interface.

Hopefully, using a .zip instead of a .pdf file for our doc examples should fix it

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 29, 2021
@slorber
slorber requested a review from lex111 as a code owner October 29, 2021 11:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 29, 2021
@netlify

netlify Bot commented Oct 29, 2021

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: a8e58e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617be9eb9593f1000734cca3

😎 Browse the preview: https://deploy-preview-5823--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Oct 29, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5823--docusaurus-2.netlify.app/

@github-actions

github-actions Bot commented Oct 29, 2021

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 38 kB
website/build/assets/css/styles.********.css 94 kB
website/build/assets/js/main.********.js 425 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB
website/build/blog/index.html 39 kB
website/build/docs/index.html 46.1 kB
website/build/docs/installation/index.html 53.6 kB
website/build/index.html 31.6 kB
website/build/tests/docs/index.html 27.3 kB
website/build/tests/docs/standalone/index.html 23.8 kB

compressed-size-action

@slorber slorber changed the title chore: replace doc pdf by zip to solve Crowdin issue chore: replace doc sample .pdf file by .xslx to solve Crowdin issue Oct 29, 2021
@slorber

slorber commented Oct 29, 2021

Copy link
Copy Markdown
Collaborator Author

😓 Crowdin also unzip zipped files on upload, so using a .xslx instead

@Josh-Cena Josh-Cena changed the title chore: replace doc sample .pdf file by .xslx to solve Crowdin issue chore: replace doc sample .pdf file by .xlsx to solve Crowdin issue Oct 29, 2021
@slorber
slorber merged commit 157b41c into main Oct 29, 2021
@slorber
slorber deleted the slorber/remove-pdf-in-doc branch October 29, 2021 12:46
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants