Skip to content

chore(README): fix broken Github Actions Workflow Status icon - #5870

Merged
Josh-Cena merged 1 commit into
facebook:mainfrom
HemantSachdeva:main
Nov 4, 2021
Merged

chore(README): fix broken Github Actions Workflow Status icon#5870
Josh-Cena merged 1 commit into
facebook:mainfrom
HemantSachdeva:main

Conversation

@HemantSachdeva

Copy link
Copy Markdown
Contributor

Signed-off-by: Hemant Sachdeva hemant.evolver@gmail.com

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I changed the icon which was not showing up correctly in README. After I made changes icon and link to the workflow works fine now. Commit and PR number is mentioned above who broke the icon.

 * Commit 66771bd renames the file v2-tests.yml to tests.yml
   in PR facebook#5833 which broke the github actions test icon and link to the workflow.

Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @HemantSachdeva!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify

netlify Bot commented Nov 4, 2021

Copy link
Copy Markdown

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 8c75d88

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6183c4a421e15c00078daec5

😎 Browse the preview: https://deploy-preview-5870--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Nov 4, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5870--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 4, 2021
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 4, 2021
@Josh-Cena

Copy link
Copy Markdown
Collaborator

Thanks for noticing :P

@Josh-Cena Josh-Cena changed the title Fix broken Github Actions Workflow Status icon chore(README): fix broken Github Actions Workflow Status icon Nov 4, 2021
@Josh-Cena
Josh-Cena merged commit 8ccc41c into facebook:main Nov 4, 2021
@HemantSachdeva

Copy link
Copy Markdown
Contributor Author

Your welcome sir :)

mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
…ok#5870)

* Commit 1935aad renames the file v2-tests.yml to tests.yml
   in PR facebook#5833 which broke the github actions test icon and link to the workflow.

Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants