airserver: remove local/shared bundle cleaners and loadgen from OSS/client build#160
Closed
codyohl wants to merge 1 commit into
Closed
airserver: remove local/shared bundle cleaners and loadgen from OSS/client build#160codyohl wants to merge 1 commit into
codyohl wants to merge 1 commit into
Conversation
…lient build Summary: some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50094943 |
codyohl
added a commit
to codyohl/sapling
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/wangle
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/watchman
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/rust-shed
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/edencommon
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/hsthrift
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/katran
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/openr
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/proxygen
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/edencommon
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/fizz
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/fizz
that referenced
this pull request
Oct 23, 2023
…lient build (facebookincubator#100) Summary: X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/proxygen
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: 1b43aa9fc98ecac28be83076618f4dd19bdfd0b4
codyohl
added a commit
to codyohl/velox
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835
codyohl
added a commit
to codyohl/edencommon
that referenced
this pull request
Oct 23, 2023
…lient build (facebookexperimental#12) Summary: X-link: facebookincubator/fizz#100 Pull Request resolved: facebookexperimental#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: 5cc813cfbce1aca93c0396ce418ae68a67c58cfa
codyohl
added a commit
to codyohl/fizz
that referenced
this pull request
Oct 23, 2023
…lient build (facebookincubator#100) Summary: Pull Request resolved: facebookincubator#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: 8395dd536cfb074f05f240e211728a913c64a527
codyohl
added a commit
to codyohl/openr
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: b926c5b16a24820ea8a6c9aa74be36934a730d33
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 23, 2023
…lient build (#41) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 Pull Request resolved: #41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 23, 2023
…lient build (#118) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 Pull Request resolved: #118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 23, 2023
…lient build (#319) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 Pull Request resolved: #319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 23, 2023
…lient build (#100) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 Pull Request resolved: #100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
Contributor
|
This pull request has been merged in 7ceb084. |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 23, 2023
…lient build (#7196) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 Pull Request resolved: #7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 23, 2023
…lient build (#581) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 Pull Request resolved: #581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 23, 2023
…lient build (#1170) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 Pull Request resolved: #1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 23, 2023
…lient build (#42) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 Pull Request resolved: #42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 23, 2023
…lient build (#468) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 Pull Request resolved: #468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 23, 2023
…lient build (#12) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 Pull Request resolved: #12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 23, 2023
…lient build Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jan 9, 2024
…lient build (#149) Summary: Pull Request resolved: #149 X-link: https://github.com/facebookexternal/traffixr/pull/2 X-link: facebookincubator/velox#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
raghav-nexthop
pushed a commit
to nexthop-ai/fboss
that referenced
this pull request
Feb 6, 2026
# Summary FBOSS OSS can now optionally be built with clang by passing a new `--use-clang` flag to the script script. When that flag is passed the FBOSS container will default using clang however the command `use-gcc` can be used to switch back to gcc12 if needed, and the command `use-clang` can then be used to switch back to clang. The same container can be used to build FBOSS with both compilers by switching back and forth between the two seamlessly. Note that the same gcc-built SAI/SDK can be used when building FBOSS with clang. It's not necessary to rebuild the SAI/SDK with clang. - Add `--use-clang` flag to `docker-build.py` to build with LLVM toolchain, in which case we put a full blown clang install in the Docker image and configure it as the default compiler. - Auto-detect clang in `run-getdeps.py` and set compiler flags needed as clang tends to be stricter than gcc. Re-use compiler flags from `CMakeLists.txt` to avoid duplication. - Make sure we don't install `binutils` as the entire toolchain is either provided by gcc12 or by clang, and binutils creates some paths such as `/usr/bin/ar` that aren't symlinks and thus can't be swapped out by using `update-alternatives`. - Prepend clang flags to user environment variables for override capability - Link using clang's linker, `lld`, which is way faster (more than 6x!). - Add fmt consteval patch for clang 21+ compatibility. - Fix `qsfp_hw_test` duplicate `main()` by using `fboss_init` instead of `hw_test_main` as gcc was accepting to link this incorrect program where the binary has two `main()` functions. - Disable range-v3 tests and perf benchmarks to speed up builds and work around some clang specific build failures that don't matter to FBOSS. - Fix insufficient forward declaration and unused variable warnings. # Test Plan Without `--use-clang` there is no change. With `--use-clang` FBOSS can be built, all the unit tests pass, and end to end tests on a minipack3 device pass. Switching back to GCC with `use-gcc` and running the build works.
Alan-S-Andrade
pushed a commit
to Alan-S-Andrade/velox
that referenced
this pull request
Jun 2, 2026
…lient build (facebookincubator#7196) Summary: X-link: facebook/openr#149 X-link: https://github.com/facebookexternal/traffixr/pull/2 Pull Request resolved: facebookincubator#7196 X-link: facebookincubator/fizz#100 X-link: facebookexperimental/edencommon#12 X-link: facebook/proxygen#468 X-link: https://github.com/facebookincubator/zstrong/pull/609 X-link: facebookincubator/hsthrift#118 X-link: facebookincubator/crux#9 X-link: facebookexperimental/rust-shed#42 X-link: facebook/watchman#1170 X-link: facebook/mvfst#319 X-link: facebook/fbthrift#581 X-link: facebook/fboss#160 X-link: facebook/fb303#41 some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side Reviewed By: DevSatpathy Differential Revision: D50094943 Privacy Context Container: L1091835 fbshipit-source-id: fda385715f8c792667c942e23ceccd5a6b8696d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: some cleanup: remove loadgen and bundle cleaners from client build and OSS build - hopefully will let us move faster in these codebases and avoid needing to upkeep the OSS side
Reviewed By: DevSatpathy
Differential Revision:
D50094943
Privacy Context Container: L1091835