airstore: remove getdeps manifest, getdeps sandcastle integration#199
Closed
codyohl wants to merge 1 commit into
Closed
airstore: remove getdeps manifest, getdeps sandcastle integration#199codyohl wants to merge 1 commit into
codyohl wants to merge 1 commit into
Conversation
Summary: X-link: facebook/wangle#233 X-link: facebookexperimental/rust-shed#54 X-link: facebookincubator/hsthrift#132 X-link: https://github.com/facebookincubator/zstrong/pull/846 takes AIRStore off of getdeps! - remove our manifest file - remove our native-getdeps sandcastle integration Differential Revision: D57985865
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57985865 |
raghav-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Feb 6, 2026
**Pre-submission checklist** - [X] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [X] `pre-commit run` # Summary ArtifactStore provides persistent storage for various distro_cli artifacts. ArtifactStore is designed to provide persistent storage for distro_cli artifacts. At the heart, the design separates artifact storage from cache validation logic. Unlike traditional caching systems that embed validation logic such as lookups, timestamps, or checksum-based checks, ArtifactStore delegates cache evaluation to caller-provided functions, enabling component-specific caching strategies without coupling the cache layer to any particular validation mechanism. Design: Lazy Evaluation: The get() method accepts a fetch_fn callback that receives cached files and determines cache validity. This allows each component to implement custom validation logic (e.g., version checks, checksums) without modifying the cache layer. Data/Metadata Separation: Artifacts are stored in separate data/ and metadata/ subdirectories, enabling efficient metadata-only operations (e.g., ETag validation) without transferring large data files. Store Keys: Store keys are hashed to create filesystem-safe subdirectories, preventing collisions and enabling deterministic store lookups. Caller-Controlled Lifecycle: The store layer makes no assumptions about cache validation logic. Caller supplied fetch_fn explicitly controls cache updates by returning (cache_hit, new_files, new_metadata) from their fetch functions. The above design supports diverse artifact caching scenarios—from simple file-based builds to remote artifact downloads with conditional requests. # Test Plan Added unit tests. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/wangle#233
X-link: facebookexperimental/rust-shed#54
X-link: facebookincubator/hsthrift#132
X-link: https://github.com/facebookincubator/zstrong/pull/846
takes AIRStore off of getdeps!
Differential Revision: D57985865