pzstd: add --stream-size option for stdin compression - #4759
Open
VirajMishra1 wants to merge 1 commit into
Open
Conversation
Add --stream-size flag to pzstd, matching the existing flag in the main zstd CLI. When compressing from stdin/pipe, this tells the compressor the total input size, enabling it to write the content size in the frame header and optimize window size for better compression ratios. Closes facebook#3171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--stream-size=Nto pzstd, matching the existing flag in the mainzstdCLI. When compressing from stdin/pipe, this tells the compressor the total input size so it can:ZSTD_getParams/ZSTD_adjustCParamsWithout this flag, pzstd compressing from stdin has no way to communicate the input size to the compression context, resulting in suboptimal compression parameters.
Changes (all within
contrib/pzstd/):Options.h-- addedstreamSrcSizefield, passed toZSTD_getParams()andZSTD_adjustCParams()indetermineParameters()Options.cpp-- addedparseUnsignedLL()helper (matches existingparseUnsignedstyle),--stream-sizeparsing with=and space-separated syntax, usage textPzstd.cpp-- when input is stdin andstreamSrcSize > 0, use it asinputSizeinstead of 0test/OptionsTest.cpp-- addedStreamSizetest covering both syntaxes, missing argument, non-numeric argument, and default valueBuild succeeds, round-trip smoke test passes.
Closes #3171