Skip to content

feat(locale): add animal data for az - #4075

Merged
ST-DDT merged 4 commits into
faker-js:nextfrom
jamalkamaladdin:feat/az-animal
Sep 12, 2026
Merged

ST-DDT merged 4 commits into
faker-js:nextfrom
jamalkamaladdin:feat/az-animal

Conversation

@jamalkamaladdin

@jamalkamaladdin jamalkamaladdin commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This PR adds animal data for the az locale.

New files src/locales/az/animal: 16 files, 256 entries. The names are the ones used in Azerbaijani, so some lists are shorter than the English source.
Index files generated with pnpm run generate:locales.

@jamalkamaladdin
jamalkamaladdin requested a review from a team as a code owner September 7, 2026 07:21
@netlify

netlify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a995a98
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6aa42ca9dcd8330008b04fd9
😎 Deploy Preview https://deploy-preview-4075.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (6ddc62d) to head (a995a98).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4075      +/-   ##
==========================================
- Coverage   99.14%   99.08%   -0.06%     
==========================================
  Files        1112     1113       +1     
  Lines        3731     3732       +1     
  Branches      649      649              
==========================================
- Hits         3699     3698       -1     
- Misses         28       30       +2     
  Partials        4        4              
Files with missing lines Coverage Δ
src/locales/az/animal/index.ts 100.00% <100.00%> (ø)
src/locales/az/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Sep 7, 2026
@ST-DDT ST-DDT added this to the v11.0 milestone Sep 7, 2026
@ST-DDT

ST-DDT commented Sep 7, 2026

Copy link
Copy Markdown
Member

Tested on

pnpm run lint passes.
vitest run test/locale-data.spec.ts passes, 2842 tests.

IMO this information does not add anything to the discussion as it is the expected bar you have to pass.
If you did extra testing, that isn't part of the standard suite, that may be worth mentioning.

CI is still red though...

Please run pnpm run preflight to avoid these kind of issues in the future.

@jamalkamaladdin

Copy link
Copy Markdown
Contributor Author

Fair point, removed it from the description.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The locale integration is complete, and all 256 entries satisfy sorting and uniqueness requirements.

Pull request overview

Adds Azerbaijani animal datasets, enabling localized output across all animal APIs.

Changes:

  • Adds 256 Azerbaijani animal entries across 16 categories.
  • Registers the animal definitions in the Azerbaijani locale.
  • Adds the generated animal index.
File summaries
File Description
src/locales/az/index.ts Registers animal data.
src/locales/az/animal/index.ts Exports animal categories.
src/locales/az/animal/bear.ts Adds bear names.
src/locales/az/animal/bird.ts Adds bird names.
src/locales/az/animal/cat.ts Adds cat breeds.
src/locales/az/animal/cetacean.ts Adds cetacean names.
src/locales/az/animal/cow.ts Adds cattle breeds.
src/locales/az/animal/crocodilia.ts Adds crocodilian names.
src/locales/az/animal/dog.ts Adds dog breeds.
src/locales/az/animal/fish.ts Adds fish names.
src/locales/az/animal/horse.ts Adds horse breeds.
src/locales/az/animal/insect.ts Adds insect names.
src/locales/az/animal/lion.ts Adds lion names.
src/locales/az/animal/pet_name.ts Adds pet names.
src/locales/az/animal/rabbit.ts Adds rabbit breeds.
src/locales/az/animal/rodent.ts Adds rodent names.
src/locales/az/animal/snake.ts Adds snake names.
src/locales/az/animal/type.ts Adds general animal types.
Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I threw the lists against a translator and got the following suggestions.

Please check them as I have no knowledge in this regard.
If they are correct as is, that is also fine.

Comment thread src/locales/az/animal/cat.ts Outdated
Comment thread src/locales/az/animal/cat.ts Outdated
Comment thread src/locales/az/animal/cat.ts Outdated
Comment thread src/locales/az/animal/cetacean.ts Outdated
Comment thread src/locales/az/animal/cow.ts Outdated
Comment thread src/locales/az/animal/lion.ts Outdated
Comment thread src/locales/az/animal/rabbit.ts Outdated
Comment thread src/locales/az/animal/rodent.ts Outdated
Comment thread src/locales/az/animal/snake.ts Outdated
Comment thread src/locales/az/animal/snake.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The datasets are correctly integrated, complete, sorted, and duplicate-free.

Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@ST-DDT
ST-DDT added this pull request to the merge queue Sep 12, 2026
Merged via the queue into faker-js:next with commit bffd2f1 Sep 12, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants