✅ Fix flaky app_dir and launch tutorial tests under xdist - #1951
Open
YuriiMotov wants to merge 1 commit into
Open
✅ Fix flaky app_dir and launch tutorial tests under xdist#1951YuriiMotov wants to merge 1 commit into
app_dir and launch tutorial tests under xdist#1951YuriiMotov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
test-redistributefailed onmaster(see logs), but passed again on later commits.After investigating it with Claude Code we found a race between
xdistworkers. Three tests use the real~/.config/my-super-cli-app/config.json:test_cli_config_doesnt_existexpects the file to not existtest_cli_config_existscreates it in a fixturetest_cliintest_launch/test_tutorial002.pycreates it via the tutorial codexdistspreads tests across workers, so these tests run in parallel from time to time and then may fail.To fix this I added an
app_dirfixture intests/conftest.py. It patchestyper.get_app_dirto returntmp_path, so each test gets its own empty dir.As a bonus, tests no longer create files in the real
~/.configon developers' machines.To reproduce the flakiness on
master:AI Disclaimer
Used Claude Code (Fable 5.1) to investigate and apply the fix. Reviewed manually
Checklist