Only send www-authenticate for 401. Make realm dynamic.#40
Merged
Conversation
Eomm
approved these changes
May 7, 2021
Contributor
|
We should update index.d.ts, it is not supported now |
Contributor
|
You mean adding realm() to the typings? |
Contributor
|
@Uzlopak right! https://github.com/fastify/fastify-basic-auth/blob/master/index.d.ts#L29 It should be authenticate?: boolean | { realm: string | (request: FastifyRequest) => string }; |
Contributor
|
Can you provide a PR with a test please? |
Contributor
|
|
crutch12
added a commit
to crutch12/fastify-basic-auth
that referenced
this pull request
Sep 2, 2022
4 tasks
Contributor
mcollina
pushed a commit
that referenced
this pull request
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #39 (comment), I refactored a good part of the library.
Checklist
npm run testandnpm run benchmarkand the Code of conduct