feat: implement instanceof#149
Conversation
mcollina
left a comment
There was a problem hiding this comment.
Works for me, LGTM.
Can you document this?
|
Does the example in #86 (comment) pass with this? |
|
|
||
| // Create the index.js. It will be executed as a forked process, so we need to | ||
| // use process.send to send messages back to the parent process. | ||
| fs.writeFileSync(path.resolve(testCwd, 'index.js'), ` |
Check failure
Code scanning / CodeQL
Insecure temporary file
| // Create /node_modules/dep/index.js. It will export a function foo which will | ||
| // throw an error when called. The error will be an instance of ChildBoom, created | ||
| // by the fastify-error module in the node_modules directory of dep. | ||
| fs.writeFileSync(path.resolve(testCwd, 'node_modules', 'dep', 'index.js'), ` |
Check failure
Code scanning / CodeQL
Insecure temporary file
|
@mcollina I added some documentation. Please review again. |
|
@Fdawgs |
Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
|
Should we release it as a major or as a minor? Could be potentially better to release as major, because it is easier to track that this feature was part of v5 as v4.2.0 |
Minor, no breaking changes from what I can see? |
|
Just for support reasons. Like somebody asks, why it doesnt work, and then we just need to say, make Thats the only reason, i would say. |
|
Trying to synchronize major version numbers across all modules to the major version of the framework is a ship that sailed a long time ago. It also introduces too many difficulties (e.g. not being able to ship a major in a module that really needs one). There's a malleable database server that forces its official modules to match the major version of the database, and it results in the modules violating semver guarantees on a routine basis. We should not do the same. |
|
Allright :) |
|
@fastify/core |
|
Go for it. |
|
I dont have publish right for npm. |
|
@Uzlopak please add your npm account to the new discussion I created in the private discussions. Also, since this is a library, you'd need to be on the libraries team. Are you wanting to join that team? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Maybe a solution for #17