Skip to content

ci(plugins-ci): require quality-checks to pass#226

Merged
Fdawgs merged 1 commit into
mainfrom
Fdawgs-patch-1
Jul 20, 2026
Merged

ci(plugins-ci): require quality-checks to pass#226
Fdawgs merged 1 commit into
mainfrom
Fdawgs-patch-1

Conversation

@Fdawgs

@Fdawgs Fdawgs commented Jul 20, 2026

Copy link
Copy Markdown
Member

always() overrides the results of the needs array, so even though linting failed in fastify/busboy#220, the automerge still occurred. always() is used so fastify-dependency-integration can be skipped if not enabled.

Spotted thanks to @Tony133 in fastify/busboy#221

Checklist

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the plugins-ci workflow’s Dependabot automerge gating to prevent automerges when dependent jobs fail by removing always() from the automerge job condition.

Changes:

  • Remove always() from the automerge job’s if: condition in .github/workflows/plugins-ci.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/plugins-ci.yml
@Fdawgs Fdawgs changed the title ci(plugins-ci): stop override of needs ci(plugins-ci): require quality-checks to pass Jul 20, 2026
@Fdawgs
Fdawgs enabled auto-merge (squash) July 20, 2026 10:07
@Fdawgs
Fdawgs merged commit fa95666 into main Jul 20, 2026
3 checks passed
@Fdawgs
Fdawgs deleted the Fdawgs-patch-1 branch July 20, 2026 10:07
@Tony133

Tony133 commented Jul 22, 2026

Copy link
Copy Markdown
Member

@Fdawgs I think need.quality-check.result == 'success' is not enough, dependabot continues to bypass even if the tests have failed by doing only 2 or 3 checks (see screenshot and here: fastify/fastify-type-provider-json-schema-to-ts#147)

screenshot

@Fdawgs

Fdawgs commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@Tony133 this change hasn't been released or deployed anywhere yet is why. 😇

@Tony133

Tony133 commented Jul 22, 2026

Copy link
Copy Markdown
Member

@Tony133 this change hasn't been released or deployed anywhere yet is why. 😇

ah ok 😅 👍🏻, it's better to do a release, I'm blocking the upgrade to typescript v7.x because it breaks the lint, it's not compatible with eslint v9 and neostandard 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants