ci(plugins-ci): require quality-checks to pass#226
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the plugins-ci workflow’s Dependabot automerge gating to prevent automerges when dependent jobs fail by removing always() from the automerge job condition.
Changes:
- Remove
always()from theautomergejob’sif:condition in.github/workflows/plugins-ci.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Fdawgs I think
|
|
@Tony133 this change hasn't been released or deployed anywhere yet is why. 😇 |
ah ok 😅 👍🏻, it's better to do a release, I'm blocking the upgrade to |

always()overrides the results of theneedsarray, so even though linting failed in fastify/busboy#220, the automerge still occurred.always()is used so fastify-dependency-integration can be skipped if not enabled.Spotted thanks to @Tony133 in fastify/busboy#221
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct