fix(desktop): never generate summaries for too-short transcripts - #6596
fix(desktop): never generate summaries for too-short transcripts#6596ComputelessComputer wants to merge 1 commit into
Conversation
The 160-character eligibility gate only guarded the auto-enhance path, so manual regenerate, template apply, and upload flows could still produce a summary while the auto path toasted "Summary wasn't generated" for the same session — and an undischarged pending auto-enhance job kept re-firing that toast every resume cycle. - Gate EnhancerService.enhance() on transcript_too_short before any note writes, emitting the skip event and returning a too_short result (sessions without any transcript still enhance from notes) - Precheck eligibility in onRegenerate before starting the task directly - Discard the pending auto-enhance job when eligibility gives up, so the resume loop stops re-queueing and re-toasting
✅ Deploy Preview for old-char canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f524b93. Configure here.
| }); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
Silent regenerate skip off main
Medium Severity
The new regenerate precheck depends on getEnhancerService(), which is null in standalone note windows that mount with includeServices={false}. Eligibility is skipped there, requestMainEnhance still runs, and main enhance() returns too_short with the skip toast only on main—so regenerate fails with no feedback in the window where it was triggered.
Reviewed by Cursor Bugbot for commit f524b93. Configure here.
The 160-character eligibility gate only guarded the auto-enhance path,
so manual regenerate, template apply, and upload flows could still
produce a summary while the auto path toasted "Summary wasn't
generated" for the same session — and an undischarged pending
auto-enhance job kept re-firing that toast every resume cycle.
note writes, emitting the skip event and returning a too_short result
(sessions without any transcript still enhance from notes)
resume loop stops re-queueing and re-toasting
Note
Low Risk
Targeted guardrails on summary generation UX and job lifecycle; no auth, data migration, or broad architectural changes.
Overview
Unifies the transcript length gate so manual regenerate and other
EnhancerService.enhance()callers behave like auto-enhance: if a transcript exists but fails the word/character minimums (transcript_too_short), enhancement stops before any summary document writes or AI task start, emitsauto-enhance-skipped, and returns{ type: "too_short" }. Sessions with no transcript still enhance from notes only.Auto-enhance cleanup: when retries exhaust eligibility or
enhance()returnstoo_short, durable pending auto-enhance jobs are discarded so resume cycles stop re-queueing and re-toasting.UI:
onRegeneratecallscheckEligibilityfirst and shows the same “Summary wasn’t generated” warning instead of starting generation in the main window path.Reviewed by Cursor Bugbot for commit f524b93. Bugbot is set up for automated code reviews on this repo. Configure here.