Replace aredis with redis-py - #635
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 94.13% 94.09% -0.05%
==========================================
Files 102 102
Lines 11093 11100 +7
Branches 1327 1328 +1
==========================================
+ Hits 10442 10444 +2
- Misses 554 557 +3
- Partials 97 99 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Faust doesn't work with ardis, because aredis support by python until 3.8. Miracle, python 3.9 is working with aredis, Faust with 3.11 doesn't work. We move with aredis to redis-py 🙏 |
Member
Author
|
I'm waiting to merge this until I've tested this against an actual Redis instance. |
wbarnha
marked this pull request as ready for review
November 19, 2024 02:01
Member
Author
|
We're going to have to get this merged if we want to support newer versions of Python. |
wbarnha
added a commit
that referenced
this pull request
Jul 19, 2026
* docs: correct stale dependency and version references The user-facing docs still carried robinhood-era and pre-0.12 details: - `redis` extra listed the long-deprecated `aredis`; it is backed by `redis-py` now (since #635). - The "What do I need?" sidebar claimed Python 3.8 while the prose right below it already says 3.10 (the real minimum) - align it to 3.10. - Dropped two stale "Faust version 1.0" self-references. - Document the `faust[ckafka]` bundle (confluent-kafka / `confluent://` transport), which had no mention in the install docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHPL4VFWQRQPpjR1gXSKyL * docs: refresh copyright year and document missing extras - Bump the docs copyright to 2026 and note the faust-streaming project's continued maintenance (docs/conf.py and copyright.rst). - Document the install bundles that existed but were undocumented: `faust[rocksdict]` (Stores), and `faust[prometheus]` / `faust[sentry]` (Sensors). Left `aerospike` out on purpose: it ships a requirements file but is not in setup.py's BUNDLES, so `faust[aerospike]` is not an installable extra. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHPL4VFWQRQPpjR1gXSKyL --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to get
aredisout of Faust since it usesdistutils, a library removed in Python 3.12.