Skip to content

Fix jcpan build-directory exhaustion #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 1 commit into from
Aug 3, 2026
Merged

Fix jcpan build-directory exhaustion #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/main/perl/lib/CPAN/Distribution.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,13 +591,30 @@ See also http://rt.cpan.org/Ticket/Display.html?id=38932\n");
my $packagedir;
my $eexist = ($CPAN::META->has_usable("Errno") && defined &Errno::EEXIST)
? &Errno::EEXIST : undef;
for(my $suffix = 0; ; $suffix++) {
my $suffix = 0;
my $unique_suffix = 0;
while (1) {
$packagedir = File::Spec->catdir($builddir, "$tdir_base-$suffix");
my $parent = $builddir;
mkdir($packagedir, 0777) and last;
if((defined($eexist) && $! != $eexist) || $suffix == 999) {
if(defined($eexist) && $! != $eexist) {
$CPAN::Frontend->mydie("Cannot create directory $packagedir: $!\n");
}
# CPAN normally leaves completed build directories in the cache and
# uses a bounded numeric suffix to avoid overwriting them. A long
# sequence of interrupted or repeated builds can exhaust -0 .. -999,
# though, making an otherwise healthy CPAN cache unusable. Continue
# with a collision-safe suffix instead of failing at an arbitrary
# limit. mkdir remains the atomic operation, so concurrent CPAN
# clients cannot select the same directory.
if ($suffix == 999) {
$unique_suffix = 1;
}
if ($unique_suffix) {
$suffix = join '-', time, $$, int(rand(1_000_000));
} else {
$suffix++;
}
}
my $f;
for $f (@dirents) { # is already without "." and ".."
Expand Down
Loading