Conversation
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
lukisch
changed the base branch from
master
to
fix/codex-checksum-close-lifecycle-20261001
October 1, 2026 10:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #15. This PR is based on
fix/codex-checksum-close-lifecycle-20261001; its diff contains only the six delete-fix files. The integration commit normally merges the reviewed checksum/GUI-GC fix, without a second checksum implementation.Windows deletion of a folder containing a read-only regular file previously failed with WinError 5. Retry once only for that specific case after clearing the read-only attribute; propagate ACL/sharing failures, restore the original attribute after a failed retry, and never follow symlink or junction targets. Read-only files with multiple hardlinks deliberately keep their original error so surviving aliases retain their attributes. The original user's folder cause remains unconfirmed.
Adds the existing translated “Vor dem Löschen nachfragen” checkbox to the Edit menu. It defaults on, immediately controls all delete entry points, persists in JSON, and stays synchronized with Settings. Only explicit JSON false disables confirmation.
Validation of integration head
3e4331d255c2d25aa2760036f150e0a315283466, tree8ba4fff5603c2ba35d144f218fcb20d834fa31a4:Remote CI 36851619258 for this exact head completed successfully: all nine Windows/Linux/macOS × Python 3.10/3.11/3.12 matrix jobs passed. On the previous delete-only head 673ec27, 8/9 matrix jobs passed and Ubuntu/Python 3.11 crashed in the checksum-close test twice; this integration uses the existing repair in #15. No version, Store, release or license changes.