This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Repository navigation
make basic layers an enum and work with subtyping - #8
Merged
Merged
Conversation
deltheil
previously approved these changes
Aug 17, 2023
limiteinductive
force-pushed
the
pr/make-basic-layers-work-with-subtyping
branch
from
August 17, 2023 13:11
7ffb8e3 to
780631a
Compare
deltheil
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this issue
With this commit, diffusers 19.x introduces subtyping of basic layers (e.g. LoRALinearLayer).
-> We solve this by storing basic layers as a
type[Module]enum, and checking for type instead of__class__.__name__Current conversion tool should work as is.